Code review comment for lp:~gothicx/entertainer/add_xpm_icon

Revision history for this message
Matt Layman (mblayman) wrote :

Hello,

I checked the log and the reason I conceded for including the xpm is not to satisfy desktop managers that don't support hicolor (because there is a good chance that those desktop managers won't support the hardware acceleration needed to run Entertainer). The reason was to satisfy lintian for Debian. But the reason doesn't really matter except to clarify my motivation for landing this branch.

What I was hoping would come out of this branch is that Marco would make the modifications to setup.py needed in order to put the file in the proper place. Since I have not seen any follow up commits, I haven't taken any action to approve the branch. Just adding an xpm file is not going to be good enough. We need to make sure that it gets installed too! :)

In my mind, this branch is simply incomplete in its current state. Hopefully that clears things up for you, Samuel.

« Back to merge proposal