Merge lp:~gothicx/entertainer/add_xpm_icon into lp:entertainer

Proposed by Marco Rodrigues
Status: Work in progress
Proposed branch: lp:~gothicx/entertainer/add_xpm_icon
Merge into: lp:entertainer
Diff against target: None lines
To merge this branch: bzr merge lp:~gothicx/entertainer/add_xpm_icon
Reviewer Review Type Date Requested Status
Samuel Buffet (community) Approve
Matt Layman Needs Fixing
Review via email:
To post a comment you must log in.
Revision history for this message
Matt Layman (mblayman) wrote :

Marco, you need to help us out here. I have no idea why you want to add an xpm icon to Entertainer. You've provided no rationale or synopsis, and for that reason alone, I'm tempted to disapprove this proposal.

You must have a reason for proposing this branch, but my telepathic powers aren't strong enough to read your mind. :)

Please provide some context so I can understand why we should consider adding this file to Entertainer. Is it stated in the Debian Policy Manual that xpm files are needed for all packages that are in the archive?

I've seen plenty of packages that don't include xpm files so you need to sell this concept to me before I consider approving it. References will be helpful to your cause.

In the future, please provide an initial summary comment to your merge proposals or I will be strongly inclined to disapprove the proposal immediately. I don't do it to be mean, but I, as a reviewer, need to understand why a proposed change should be made before I spend any of my free time reviewing some code.

review: Needs Fixing
Revision history for this message
Marco Rodrigues (gothicx) wrote :


First of all, I'm sorry about not commenting it. I'll don't forget in the future. I want the xpm icon, because it's needed/useful for debian / fedora / put_your_distro_here / xfce desktop / gnome, etc. It's only useful for packaging and some desktop managers that doesn't support hicolor icons.

I think lintian warns in debian about not having an xpm icon, so if there are packages without it, it's because Debian Developers ignore it.


Revision history for this message
Samuel Buffet (samuel-buffet) wrote :

bom dia Marco,

+1 with Matt for the missing comment.

I'm ok with this new icon if you think that's better from a packaging point of view.


review: Approve
Revision history for this message
Matt Layman (mblayman) wrote :

I'm going to continue to play devil's advocate because I still have questions about the purpose of this branch.

1) If xpm files are only for window managers that don't support hicolor, do those window managers support clutter? We use gtk to contain clutter so do these other window managers support gtk. Remember, more importantly, we've only committed to supporting Gnome and Xfce in our purpose statement (e.g., we don't even pretend to be a directly supported KDE application). So unless Xfce doesn't support hicolor icons, then I don't see a need for xpm because we know Gnome supports hicolor.

2) This work seems incomplete because the setup file hasn't changed. I'd guess that just putting the xpm file in the icons directory does not put the file in the correct place for the package. How would running `python install` put the xpm file in the correct location?

Revision history for this message
Samuel Buffet (samuel-buffet) wrote :

Hi Marco,

Can something happen here?

There's no progress on that discussion so ... we regress :(

Marco, can you provide us a link arguing that this xmp file is needed in Entertainer?

If there's no progress in the next weeks, I'll may remove that proposal to cleanup our proposal queue.


Revision history for this message
Marco Rodrigues (gothicx) wrote :


I've already talked with Matt about this proposal some time ago at #entertainer channel and we need to handle this situation. I don't know if he still remember about that. I don't have the channel log about it. He agreed that we need to include it for desktop managers that doesn't support hicolor icons.


Revision history for this message
Samuel Buffet (samuel-buffet) wrote :


So now the question is what do we have to do with this xpm?

Where to copy it?
When to copy it? (every time or only for xfce?)

Matt, Marco do you already have an idea about that?


Revision history for this message
Matt Layman (mblayman) wrote :


I checked the log and the reason I conceded for including the xpm is not to satisfy desktop managers that don't support hicolor (because there is a good chance that those desktop managers won't support the hardware acceleration needed to run Entertainer). The reason was to satisfy lintian for Debian. But the reason doesn't really matter except to clarify my motivation for landing this branch.

What I was hoping would come out of this branch is that Marco would make the modifications to needed in order to put the file in the proper place. Since I have not seen any follow up commits, I haven't taken any action to approve the branch. Just adding an xpm file is not going to be good enough. We need to make sure that it gets installed too! :)

In my mind, this branch is simply incomplete in its current state. Hopefully that clears things up for you, Samuel.

Unmerged revisions

374. By Marco Rodrigues

Add XPM icon

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'icons/entertainer.xpm'
2--- icons/entertainer.xpm 1970-01-01 00:00:00 +0000
3+++ icons/entertainer.xpm 2009-05-06 23:24:09 +0000
4@@ -0,0 +1,119 @@
5+/* XPM */
6+static char *entertainer[] = {
7+/* columns rows colors chars-per-pixel */
8+"24 24 89 1",
9+" c #040404",
10+". c #0C0C0C",
11+"X c gray6",
12+"o c #101010",
13+"O c gray7",
14+"+ c #131313",
15+"@ c gray8",
16+"# c #151515",
17+"$ c gray9",
18+"% c #181818",
19+"& c #191919",
20+"* c gray10",
21+"= c #1B1B1B",
22+"- c gray11",
23+"; c #1D1D1D",
24+": c #1E1E1E",
25+"> c gray12",
26+", c #202020",
27+"< c gray13",
28+"1 c #232323",
29+"2 c gray14",
30+"3 c #252525",
31+"4 c gray15",
32+"5 c #272727",
33+"6 c #282828",
34+"7 c gray16",
35+"8 c #2A2A2A",
36+"9 c gray17",
37+"0 c #2C2C2C",
38+"q c #2D2D2D",
39+"w c gray18",
40+"e c #2F2F2F",
41+"r c gray19",
42+"t c #323232",
43+"y c gray20",
44+"u c #343434",
45+"i c #353535",
46+"p c gray21",
47+"a c #373737",
48+"s c #393939",
49+"d c #3A3A3A",
50+"f c gray23",
51+"g c #3C3C3C",
52+"h c gray24",
53+"j c #3E3E3E",
54+"k c #3F3F3F",
55+"l c gray25",
56+"z c #414141",
57+"x c gray26",
58+"c c #444444",
59+"v c gray27",
60+"b c #484848",
61+"n c gray29",
62+"m c #4B4B4B",
63+"M c gray30",
64+"N c #505050",
65+"B c #515151",
66+"V c gray32",
67+"C c #585858",
68+"Z c gray35",
69+"A c #5A5A5A",
70+"S c #5F5F5F",
71+"D c #626262",
72+"F c #686868",
73+"G c gray42",
74+"H c gray44",
75+"J c #717171",
76+"K c #777777",
77+"L c #797979",
78+"P c gray49",
79+"I c #808080",
80+"U c #838383",
81+"Y c gray52",
82+"T c #979797",
83+"R c #9D9D9D",
84+"E c #9F9F9F",
85+"W c #ACACAC",
86+"Q c #B2B2B2",
87+"! c gray70",
88+"~ c #B7B7B7",
89+"^ c gray73",
90+"/ c #C1C1C1",
91+"( c #C5C5C5",
92+") c #C8C8C8",
93+"_ c #CBCBCB",
94+"` c #CECECE",
95+"' c #D5D5D5",
96+"] c #E4E4E4",
97+"[ c None",
98+/* pixels */
111+"[[[[ wJE('`)/^!W~_T[[[[[",
112+"[[[[ .#;6VFHKPUYHc$[[[[[",
113+"[[[[ .#;4ealbBZDMt$[[[[[",
114+"[[[[ .#;4ealbBZDMt$[[[[[",
115+"[[[[ .#;4ealbBZDMt$[[[[[",


People subscribed via source and target branches