Code review comment for lp:~gothicx/apport/retrace_installed_none

Revision history for this message
Martin Pitt (pitti) wrote :

http://bazaar.launchpad.net/~gothicx/apport/retrace_installed_none/revision/1595:

> hdr['Tags'] += ' ' + report['DistroRelease'].split()[0].lower + ' ' + report['DistroRelease'].split()[2]

This has some problems:

 * It will immediately crash because "lower" is a function, not a function call. This obviously hasn't been tested.
 * We should not assume that lsb_release delivers a code name on all distributions out there, so it should be tested more carefully first.
 * There is no need to add a tag for the first field. The bugs will already be filed against the "Ubuntu" distribution in Launchpad, tagging them all with "ubuntu" is just redundant.

http://bazaar.launchpad.net/~gothicx/apport/retrace_installed_none/revision/1596:

Can you please reproduce this locally with python-apt first, and perhaps put this as a reproducer into the test suite? I suppose this happens with virtual packages or something similar. Simply papering over the faulty case merely hides the underlying problem.

review: Needs Fixing

« Back to merge proposal