Unity

Merge lp:~gordallott/unity/fix-highlight-showing-on-nonexpandable-groups into lp:unity

  1. fix-highlight-showing-on-nonexpandable-groups
  2. Merge into trunk
Proposed by Gord Allott
Status: Rejected
Rejected by: Andrea Azzarone
Proposed branch: lp:~gordallott/unity/fix-highlight-showing-on-nonexpandable-groups
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
dash/PlacesGroup.cpp (+1/-1)
To merge this branch: bzr merge lp:~gordallott/unity/fix-highlight-showing-on-nonexpandable-groups
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Disapprove
Michal Hruby (community) Needs Fixing
Review via email: mp+128886@code.launchpad.net

Commit message

fix highlight showing on groups that can not be expanded

Description of the change

fix highlight showing on groups that can not be expanded

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

The group header no longer highlights now, but it's still keynav-able, the bug says it shouldn't be.

review: Needs Fixing
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Also I'm quite sure that some AP tests need to be updated.

Revision history for this message
Andrea Azzarone (azzar1) :
review: Disapprove

Unmerged revisions

2659. By Gord Allott

latest trunk

2658. By Gord Allott

fix highlight showing on groups that can not be expanded

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/PlacesGroup.cpp'
2--- dash/PlacesGroup.cpp 2012-10-08 06:36:17 +0000
3+++ dash/PlacesGroup.cpp 2012-10-10 09:09:33 +0000
4@@ -598,7 +598,7 @@
5
6 bool PlacesGroup::ShouldBeHighlighted() const
7 {
8- return HeaderHasKeyFocus();
9+ return HeaderHasKeyFocus() && (_n_total_items > _n_visible_items_in_unexpand_mode);
10 }
11
12 //