Merge lp:~googol-deactivatedaccount/openlp/bug-718797-2.0 into lp:openlp/2.0
Proposed by
Andreas Preikschat
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Andreas Preikschat | ||||
Proposed branch: | lp:~googol-deactivatedaccount/openlp/bug-718797-2.0 | ||||
Merge into: | lp:openlp/2.0 | ||||
Diff against target: |
82 lines (+44/-0) 1 file modified
openlp/core/ui/slidecontroller.py (+44/-0) |
||||
To merge this branch: | bzr merge lp:~googol-deactivatedaccount/openlp/bug-718797-2.0 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
OpenLP Core | Pending | ||
Review via email: mp+185670@code.launchpad.net |
Description of the change
Hello,
- separate blank buttons again (#718797)
I backported this, because we were asked often to do this. This can be a little "surprise feature".
Is it alright for you to merge this eventhough it is a new feature?
To post a comment you must log in.
Unmerged revisions
- 2170. By Andreas Preikschat
-
fixed bug 718797 (RFE Separate blank buttons)
I fear this could be the start of a slippery slope. We managed to introduce a bug into 2.0.2 without adding new features. If we start adding a little surprise feature here and there, no matter how small, then more little bugs could creep in.
My personal opinion is that we should stick to bug fixes in 2.0.