Noise

Merge lp:~gonz-it/noise/fix-1079763 into lp:~elementary-apps/noise/trunk

  1. fix-1079763
  2. Merge into trunk
Proposed by Gonzalo Fernandez
Status: Merged
Merged at revision: 1203
Proposed branch: lp:~gonz-it/noise/fix-1079763
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 15 lines (+6/-0)
1 file modified
src/Widgets/StatusBar.vala (+6/-0)
To merge this branch: bzr merge lp:~gonz-it/noise/fix-1079763
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Victor Martinez (community) Approve
Review via email: mp+135739@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) wrote :

Cool cool +1

review: Approve
Revision history for this message
Danielle Foré (danrabbit) wrote :

As I commented on the report, I think personally I would rather remove the resize grip (since we have a large invisible resize area all the way around the window). But I'm not opposed to this branch either.

review: Approve
Revision history for this message
David Gomes (davidgomes) wrote :

Alright, merged it in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/StatusBar.vala'
2--- src/Widgets/StatusBar.vala 2012-11-06 17:20:02 +0000
3+++ src/Widgets/StatusBar.vala 2012-11-22 17:14:22 +0000
4@@ -218,6 +218,12 @@
5 private class InfoPanelChooser : SimpleOptionChooser {
6
7 public InfoPanelChooser () {
8+ //To avoid the InfoPanelChooser to overlap with the window resize grip
9+ //Get the grip width
10+ int resize_grip_width;
11+ App.main_window.style_get ("resize-grip-width", out resize_grip_width);
12+ //Use the actual grip width as right margin
13+ margin_right = resize_grip_width;
14 var info_panel_show = Icons.PANE_SHOW_SYMBOLIC.render_image (Gtk.IconSize.MENU);
15 var info_panel_hide = Icons.PANE_HIDE_SYMBOLIC.render_image (Gtk.IconSize.MENU);
16

Subscribers

People subscribed via source and target branches