Code review comment for ~goneri/cloud-init:freebsd_set_password

Revision history for this message
Chad Smith (chad.smith) wrote :

This looks good to me Gonéri, the only thing we 'lose' in terms of behavior:
 - visibility to log message distinguishing whether we are hashed or not
 - bailing on first set_passwd error instead of trying to set all and raising errors at the end

The second point I'd like to fix.

« Back to merge proposal