Merge lp:~goelkunal/ubuntu/natty/gst-plugins-bad0.10/revision62 into lp:ubuntu/natty/gst-plugins-bad0.10

Proposed by KunalGoel
Status: Merged
Merged at revision: 60
Proposed branch: lp:~goelkunal/ubuntu/natty/gst-plugins-bad0.10/revision62
Merge into: lp:ubuntu/natty/gst-plugins-bad0.10
Diff against target: 222 lines (+198/-0)
4 files modified
debian/changelog (+11/-0)
debian/patches/0001-fpsdisplaysink-add-properties-to-get-dropped-and-ren.patch (+142/-0)
debian/patches/fpsdisplaysink_sync_default_value.patch (+43/-0)
debian/patches/series (+2/-0)
To merge this branch: bzr merge lp:~goelkunal/ubuntu/natty/gst-plugins-bad0.10/revision62
Reviewer Review Type Date Requested Status
Steve Langasek Pending
Review via email: mp+54726@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-03-22 13:16:21 +0000
3+++ debian/changelog 2011-03-24 16:22:30 +0000
4@@ -1,3 +1,14 @@
5+gst-plugins-bad0.10 (0.10.21-1ubuntu8) natty; urgency=low
6+
7+ * debian/patches/0001-fpsdisplaysink-add-properties-to-get-dropped-and-ren.patch
8+ - change frames_rendered and frames_dropped from guint64 to gint
9+ and make them atomic
10+
11+ * debian/patches/fpsdisplaysink_sync_default_value.patch
12+ - fix sync property default value
13+
14+ -- Kunal Goel <kunal.goel@linaro.org> Thu, 24 Mar 2011 20:04:08 +0530
15+
16 gst-plugins-bad0.10 (0.10.21-1ubuntu7) natty; urgency=low
17
18 * debian/control.in
19
20=== added file 'debian/patches/0001-fpsdisplaysink-add-properties-to-get-dropped-and-ren.patch'
21--- debian/patches/0001-fpsdisplaysink-add-properties-to-get-dropped-and-ren.patch 1970-01-01 00:00:00 +0000
22+++ debian/patches/0001-fpsdisplaysink-add-properties-to-get-dropped-and-ren.patch 2011-03-24 16:22:30 +0000
23@@ -0,0 +1,142 @@
24+From 2cebc40ca189ba6d23e3170d51d280daead281ff Mon Sep 17 00:00:00 2001
25+From: benjamin gaignard <benjamin.gaignard@linaro.org>
26+Date: Wed, 16 Mar 2011 09:50:34 +0100
27+Subject: [PATCH] fpsdisplaysink: add properties to get dropped and rendered values
28+ change frames_rendered and frames_dropped from guint64 to gint
29+ and make them atomic
30+
31+---
32+ gst/debugutils/fpsdisplaysink.c | 33 ++++++++++++++++++++++++++-------
33+ gst/debugutils/fpsdisplaysink.h | 11 ++++-------
34+ 2 files changed, 30 insertions(+), 14 deletions(-)
35+
36+diff --git a/gst/debugutils/fpsdisplaysink.c b/gst/debugutils/fpsdisplaysink.c
37+index aca421c..85776a5 100644
38+--- a/gst/debugutils/fpsdisplaysink.c
39++++ b/gst/debugutils/fpsdisplaysink.c
40+@@ -81,7 +81,9 @@ enum
41+ ARG_FPS_UPDATE_INTERVAL,
42+ ARG_MAX_FPS,
43+ ARG_MIN_FPS,
44+- ARG_SIGNAL_FPS_MEASUREMENTS
45++ ARG_SIGNAL_FPS_MEASUREMENTS,
46++ ARG_DROPPED,
47++ ARG_RENDERED
48+ /* FILL ME */
49+ };
50+
51+@@ -148,6 +150,17 @@ fps_display_sink_class_init (GstFPSDisplaySinkClass * klass)
52+ "-1 means no measurement has yet been done", -1, G_MAXDOUBLE, -1,
53+ G_PARAM_STATIC_STRINGS | G_PARAM_READABLE));
54+
55++ g_object_class_install_property (gobject_klass, ARG_DROPPED,
56++ g_param_spec_int ("frames-dropped", "dropped frames",
57++ "Number of dropped frames", 0, G_MAXINT, 0,
58++ G_PARAM_STATIC_STRINGS | G_PARAM_READABLE));
59++
60++ g_object_class_install_property (gobject_klass, ARG_RENDERED,
61++ g_param_spec_int ("frames-rendered", "rendered frames",
62++ "Number of rendered frames", 0, G_MAXINT, 0,
63++ G_PARAM_STATIC_STRINGS | G_PARAM_READABLE));
64++
65++
66+ g_object_class_install_property (gobject_klass, ARG_SIGNAL_FPS_MEASUREMENTS,
67+ g_param_spec_boolean ("signal-fps-measurements",
68+ "Signal fps measurements",
69+@@ -217,9 +230,9 @@ on_video_sink_data_flow (GstPad * pad, GstMiniObject * mini_obj,
70+
71+ gst_event_parse_qos (ev, NULL, &diff, &ts);
72+ if (diff <= 0.0) {
73+- self->frames_rendered++;
74++ g_atomic_int_inc (&self->frames_rendered);
75+ } else {
76+- self->frames_dropped++;
77++ g_atomic_int_inc (&self->frames_dropped);
78+ }
79+
80+ ts = gst_util_get_timestamp ();
81+@@ -332,8 +345,8 @@ display_current_fps (gpointer data)
82+ gdouble time_diff, time_elapsed;
83+ GstClockTime current_ts = gst_util_get_timestamp ();
84+
85+- frames_rendered = self->frames_rendered;
86+- frames_dropped = self->frames_dropped;
87++ frames_rendered = g_atomic_int_get (&self->frames_rendered);
88++ frames_dropped = g_atomic_int_get (&self->frames_dropped);
89+
90+ if ((frames_rendered + frames_dropped) == 0) {
91+ /* in case timer fired and we didn't yet get any QOS events */
92+@@ -402,8 +415,8 @@ fps_display_sink_start (GstFPSDisplaySink * self)
93+ GstPad *target_pad = NULL;
94+
95+ /* Init counters */
96+- self->frames_rendered = G_GUINT64_CONSTANT (0);
97+- self->frames_dropped = G_GUINT64_CONSTANT (0);
98++ self->frames_rendered = 0;
99++ self->frames_dropped = 0;
100+ self->last_frames_rendered = G_GUINT64_CONSTANT (0);
101+ self->last_frames_dropped = G_GUINT64_CONSTANT (0);
102+ self->max_fps = -1;
103+@@ -552,6 +565,12 @@ fps_display_sink_get_property (GObject * object, guint prop_id,
104+ case ARG_MIN_FPS:
105+ g_value_set_double (value, self->min_fps);
106+ break;
107++ case ARG_DROPPED:
108++ g_value_set_int (value, g_atomic_int_get (&self->frames_dropped));
109++ break;
110++ case ARG_RENDERED:
111++ g_value_set_int (value, g_atomic_int_get (&self->frames_rendered));
112++ break;
113+ case ARG_SIGNAL_FPS_MEASUREMENTS:
114+ g_value_set_boolean (value, self->signal_measurements);
115+ break;
116+diff --git a/gst/debugutils/fpsdisplaysink.h b/gst/debugutils/fpsdisplaysink.h
117+index 6a01663..c73c2dc 100644
118+--- a/gst/debugutils/fpsdisplaysink.h
119++++ b/gst/debugutils/fpsdisplaysink.h
120+@@ -23,7 +23,6 @@
121+ #include <gst/gst.h>
122+
123+ G_BEGIN_DECLS
124+-
125+ #define GST_TYPE_FPS_DISPLAY_SINK \
126+ (fps_display_sink_get_type())
127+ #define GST_FPS_DISPLAY_SINK(obj) \
128+@@ -34,8 +33,7 @@ G_BEGIN_DECLS
129+ (G_TYPE_CHECK_INSTANCE_TYPE((obj),GST_TYPE_FPS_DISPLAY_SINK))
130+ #define GST_IS_FPS_DISPLAY_SINK_CLASS(klass) \
131+ (G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_FPS_DISPLAY_SINK))
132+-
133+-GType fps_display_sink_get_type (void);
134++ GType fps_display_sink_get_type (void);
135+
136+ typedef struct _GstFPSDisplaySink GstFPSDisplaySink;
137+ typedef struct _GstFPSDisplaySinkClass GstFPSDisplaySinkClass;
138+@@ -44,15 +42,15 @@ struct _GstFPSDisplaySink
139+ {
140+ GstBin bin;
141+
142+- /*< private >*/
143++ /*< private > */
144+ /* gstreamer components */
145+ GstElement *text_overlay;
146+ GstElement *video_sink;
147+ GstPad *ghost_pad;
148+
149+ /* statistics */
150+- guint64 frames_rendered, last_frames_rendered;
151+- guint64 frames_dropped, last_frames_dropped;
152++ gint frames_rendered, frames_dropped;
153++ guint64 last_frames_rendered, last_frames_dropped;
154+
155+ GstClockTime start_ts;
156+ GstClockTime last_ts;
157+@@ -74,5 +72,4 @@ struct _GstFPSDisplaySinkClass
158+ };
159+
160+ G_END_DECLS
161+-
162+ #endif /* __FPS_DISPLAY_SINK_H__ */
163+--
164+1.7.0.4
165+
166
167=== added file 'debian/patches/fpsdisplaysink_sync_default_value.patch'
168--- debian/patches/fpsdisplaysink_sync_default_value.patch 1970-01-01 00:00:00 +0000
169+++ debian/patches/fpsdisplaysink_sync_default_value.patch 2011-03-24 16:22:30 +0000
170@@ -0,0 +1,43 @@
171+From 67bfe79a5c818de7b2c42453d65ba80cf429b5e9 Mon Sep 17 00:00:00 2001
172+From: benjamin gaignard <benjamin.gaignard@linaro.org>
173+Date: Mon, 28 Feb 2011 11:51:54 +0100
174+Subject: [PATCH] fpsdisplay: fix sync property default value
175+
176+---
177+ gst/debugutils/fpsdisplaysink.c | 6 ++++--
178+ 1 files changed, 4 insertions(+), 2 deletions(-)
179+
180+diff --git a/gst/debugutils/fpsdisplaysink.c b/gst/debugutils/fpsdisplaysink.c
181+index e3be1d6..5dca63d 100644
182+--- a/gst/debugutils/fpsdisplaysink.c
183++++ b/gst/debugutils/fpsdisplaysink.c
184+@@ -65,6 +65,8 @@ GST_STATIC_PAD_TEMPLATE ("sink",
185+ GST_DEBUG_CATEGORY_STATIC (fps_display_sink_debug);
186+ #define GST_CAT_DEFAULT fps_display_sink_debug
187+
188++#define DEFAULT_SYNC TRUE
189++
190+ enum
191+ {
192+ /* FILL ME */
193+@@ -116,7 +118,7 @@ fps_display_sink_class_init (GstFPSDisplaySinkClass * klass)
194+ g_object_class_install_property (gobject_klass, ARG_SYNC,
195+ g_param_spec_boolean ("sync",
196+ "Sync", "Sync on the clock (if the internally used sink doesn't "
197+- "have this property it will be ignored", TRUE,
198++ "have this property it will be ignored", DEFAULT_SYNC,
199+ G_PARAM_STATIC_STRINGS | G_PARAM_READWRITE));
200+
201+ g_object_class_install_property (gobject_klass, ARG_TEXT_OVERLAY,
202+@@ -323,7 +325,7 @@ static void
203+ fps_display_sink_init (GstFPSDisplaySink * self,
204+ GstFPSDisplaySinkClass * g_class)
205+ {
206+- self->sync = FALSE;
207++ self->sync = DEFAULT_SYNC;
208+ self->signal_measurements = DEFAULT_SIGNAL_FPS_MEASUREMENTS;
209+ self->use_text_overlay = TRUE;
210+ self->fps_update_interval = GST_MSECOND * DEFAULT_FPS_UPDATE_INTERVAL_MS;
211+--
212+1.7.0.4
213+
214
215=== modified file 'debian/patches/series'
216--- debian/patches/series 2011-03-07 10:39:03 +0000
217+++ debian/patches/series 2011-03-24 16:22:30 +0000
218@@ -1,2 +1,4 @@
219 99_ltmain_as-needed.patch
220 01_soundtouch-pc.patch
221+0001-fpsdisplaysink-add-properties-to-get-dropped-and-ren.patch
222+fpsdisplaysink_sync_default_value.patch

Subscribers

People subscribed via source and target branches

to all changes: