Merge lp:~godricglow/postorius/bug_login_render_fix into lp:postorius

Proposed by Pranjal Yadav
Status: Merged
Merged at revision: 196
Proposed branch: lp:~godricglow/postorius/bug_login_render_fix
Merge into: lp:postorius
Diff against target: 38 lines (+3/-7)
2 files modified
src/postorius/templates/postorius/login.html (+1/-3)
src/postorius/views/list.py (+2/-4)
To merge this branch: bzr merge lp:~godricglow/postorius/bug_login_render_fix
Reviewer Review Type Date Requested Status
Florian Fuchs Approve
Review via email: mp+248049@code.launchpad.net

Description of the change

Fixed a rendering bug on login page, corrected missplaced new line character

To post a comment you must log in.
195. By Pranjal Yadav <email address hidden>

fixed 1308219 and merged trunk

196. By Pranjal Yadav <email address hidden>

fixed a rendering bug on login page

Revision history for this message
Florian Fuchs (flo-fuchs) wrote :

Hi Pranjal,

thanks for that. Looks better now... ;-)

Florian

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/postorius/templates/postorius/login.html'
2--- src/postorius/templates/postorius/login.html 2015-01-17 17:23:59 +0000
3+++ src/postorius/templates/postorius/login.html 2015-01-29 20:32:49 +0000
4@@ -23,9 +23,7 @@
5 <input type="hidden" name="assertion" value="" />
6 <a rel="nofollow" id="browserid" href="#"><img src="{% static 'postorius/img/sign_in_blue.png' %}" alt="{% trans 'Login using BrowserID' %}" /></a>
7 </form>
8- <p>{% trans "Mozilla Persona is an easy way to sign into multiple websites, while
9-still controlling your personal data. For more information <a
10-href='http://www.mozilla.org/en-US/persona'>see the Mozilla website</a>" %}.</p>
11+ <p>{% trans "Mozilla Persona is an easy way to sign into multiple websites, while still controlling your personal data. For more information <a href='http://www.mozilla.org/en-US/persona'>see the Mozilla website</a>" %}.</p>
12 <noscript><p class="text-error">{% trans "Mozilla Persona requires the use of
13 JavaScript." %}</p></noscript>
14 </div>
15
16=== modified file 'src/postorius/views/list.py'
17--- src/postorius/views/list.py 2015-01-19 15:03:09 +0000
18+++ src/postorius/views/list.py 2015-01-29 20:32:49 +0000
19@@ -66,8 +66,6 @@
20 % request.POST['owner_email']))
21 except HTTPError as e:
22 messages.error(request, _(e.msg))
23- else:
24- owner_form = NewOwnerForm()
25 if 'moderator_email' in request.POST:
26 moderator_form = NewModeratorForm(request.POST)
27 if moderator_form.is_valid():
28@@ -79,8 +77,8 @@
29 % request.POST['moderator_email']))
30 except HTTPError as e:
31 messages.error(request, _(e.msg))
32- else:
33- moderator_form = NewModeratorForm()
34+ owner_form = NewOwnerForm()
35+ moderator_form = NewModeratorForm()
36 return render_to_response('postorius/lists/members.html',
37 {'list': self.mailing_list,
38 'owner_form': owner_form,

Subscribers

People subscribed via source and target branches