Merge lp:~godricglow/postorius/bug_1308219_fix into lp:postorius

Proposed by Pranjal Yadav
Status: Merged
Merged at revision: 195
Proposed branch: lp:~godricglow/postorius/bug_1308219_fix
Merge into: lp:postorius
Diff against target: 23 lines (+2/-4)
1 file modified
src/postorius/views/list.py (+2/-4)
To merge this branch: bzr merge lp:~godricglow/postorius/bug_1308219_fix
Reviewer Review Type Date Requested Status
Florian Fuchs Approve
Review via email: mp+248046@code.launchpad.net

Description of the change

Fixed 1308219 by avoiding else loop back and a default new.form() for both moderator and owner after submit click.

To post a comment you must log in.
195. By Pranjal Yadav <email address hidden>

fixed 1308219 and merged trunk

Revision history for this message
Florian Fuchs (flo-fuchs) wrote :

Hello Pranjal,

clearing both forms after submit makes a lot more sense than what we have now.
Approving the merge.

Thanks!

Florian

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/postorius/views/list.py'
2--- src/postorius/views/list.py 2015-01-19 15:03:09 +0000
3+++ src/postorius/views/list.py 2015-01-29 19:57:44 +0000
4@@ -66,8 +66,6 @@
5 % request.POST['owner_email']))
6 except HTTPError as e:
7 messages.error(request, _(e.msg))
8- else:
9- owner_form = NewOwnerForm()
10 if 'moderator_email' in request.POST:
11 moderator_form = NewModeratorForm(request.POST)
12 if moderator_form.is_valid():
13@@ -79,8 +77,8 @@
14 % request.POST['moderator_email']))
15 except HTTPError as e:
16 messages.error(request, _(e.msg))
17- else:
18- moderator_form = NewModeratorForm()
19+ owner_form = NewOwnerForm()
20+ moderator_form = NewModeratorForm()
21 return render_to_response('postorius/lists/members.html',
22 {'list': self.mailing_list,
23 'owner_form': owner_form,

Subscribers

People subscribed via source and target branches