Merge lp:~gnuoy/ubuntu-openstack-ci/func3 into lp:ubuntu-openstack-ci

Proposed by Liam Young
Status: Merged
Merged at revision: 394
Proposed branch: lp:~gnuoy/ubuntu-openstack-ci/func3
Merge into: lp:ubuntu-openstack-ci
Diff against target: 34 lines (+6/-4)
2 files modified
run/job-parts/build_amulet_smoke.sh (+3/-2)
run/job-parts/build_amulet_test.sh (+3/-2)
To merge this branch: bzr merge lp:~gnuoy/ubuntu-openstack-ci/func3
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Review via email: mp+342993@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

I'd be all for dropping any mention of the python version - its not really important as the charm only runs internally in py27 or py3 - and the tox target itself can define which py version it uses for execution.

So how about func and func-smoke?

lp:~gnuoy/ubuntu-openstack-ci/func3 updated
394. By Liam Young <email address hidden>

Remove py version for target name for new setups

Revision history for this message
Ryan Beisner (1chb1n) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run/job-parts/build_amulet_smoke.sh'
2--- run/job-parts/build_amulet_smoke.sh 2017-04-26 22:43:21 +0000
3+++ run/job-parts/build_amulet_smoke.sh 2018-04-11 14:20:48 +0000
4@@ -14,10 +14,11 @@
5 f_line "Begin amulet smoke"
6 cd ${BUILT_ASSET_DIR-$CO_DIR}
7 f_amulet_squash_00setup
8-if grep "^\[testenv:func27-smoke\]" tox.ini; then
9+target=$(awk 'BEGIN {FS=":"} /^\[testenv:(func27|func)-smoke\]/ {gsub(/\]/,""); print $2}' tox.ini)
10+if [[ -n $target ]]; then
11 # Look for a func27-smoke tox target and run it as the first preference.
12 f_juju_bootstrap
13- tox -e func27-smoke |& tee $WORKSPACE/amulet-smoke.txt ||:
14+ tox -e $target |& tee $WORKSPACE/amulet-smoke.txt ||:
15 if [[ "${PIPESTATUS[0]}" != "0" ]]; then
16 echo " ! Amulet smoke failed."
17 touch $WORKSPACE/fyi-amulet-smoke.failed
18
19=== modified file 'run/job-parts/build_amulet_test.sh'
20--- run/job-parts/build_amulet_test.sh 2017-04-26 22:43:21 +0000
21+++ run/job-parts/build_amulet_test.sh 2018-04-11 14:20:48 +0000
22@@ -18,9 +18,10 @@
23 f_amulet_set_timeout
24 cd ${BUILT_ASSET_DIR-$CO_DIR}
25 f_amulet_squash_00setup
26-if grep "^\[testenv:func27-smoke\]" tox.ini; then
27+target=$(awk 'BEGIN {FS=":"} /^\[testenv:(func27|func)\]/ {gsub(/\]/,""); print $2}' tox.ini)
28+if [[ -n $target ]]; then
29 f_juju_bootstrap
30- tox -e func27 |& tee $WORKSPACE/amulet-full.txt ||:
31+ tox -e $target |& tee $WORKSPACE/amulet-full.txt ||:
32 if [[ "${PIPESTATUS[0]}" != "0" ]]; then
33 echo " ! Amulet test failed."
34 touch $WORKSPACE/fyi-amulet.failed

Subscribers

People subscribed via source and target branches