Merge lp:~gnuoy/charms/trusty/swift-storage/stable-1318083 into lp:~openstack-charmers-archive/charms/trusty/swift-storage/trunk

Proposed by Liam Young
Status: Merged
Merged at revision: 32
Proposed branch: lp:~gnuoy/charms/trusty/swift-storage/stable-1318083
Merge into: lp:~openstack-charmers-archive/charms/trusty/swift-storage/trunk
Diff against target: 11 lines (+2/-1)
1 file modified
hooks/swift_storage_utils.py (+2/-1)
To merge this branch: bzr merge lp:~gnuoy/charms/trusty/swift-storage/stable-1318083
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Review via email: mp+231517@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris Glass (tribaal) wrote :

+1, this is a reasonable fix, with non-critical inline comments.

review: Approve
Revision history for this message
Liam Young (gnuoy) wrote :

I agree with your comments but I'm going to go ahead with the proposed fix unaltered as you're happy with the fix as it stands and I'm cherry-picking from the 'next' branches where the fix has been tested out by James Page.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/swift_storage_utils.py'
2--- hooks/swift_storage_utils.py 2014-07-31 10:42:35 +0000
3+++ hooks/swift_storage_utils.py 2014-08-20 07:54:40 +0000
4@@ -200,7 +200,8 @@
5 for server in ['account', 'object', 'container']:
6 url = '%s/%s.ring.gz' % (rings_url, server)
7 log('Fetching %s.' % url)
8- cmd = ['wget', url, '-O', '/etc/swift/%s.ring.gz' % server]
9+ cmd = ['wget', url, '--retry-connrefused',
10+ '-t', '10', '-O', '/etc/swift/%s.ring.gz' % server]
11 check_call(cmd)
12
13

Subscribers

People subscribed via source and target branches