Merge lp:~gnuoy/charms/trusty/quantum-gateway/conntrack into lp:~openstack-charmers/charms/trusty/quantum-gateway/next

Proposed by Liam Young
Status: Approved
Approved by: Liam Young
Approved revision: 115
Proposed branch: lp:~gnuoy/charms/trusty/quantum-gateway/conntrack
Merge into: lp:~openstack-charmers/charms/trusty/quantum-gateway/next
Diff against target: 43 lines (+7/-4)
3 files modified
hooks/quantum_utils.py (+1/-1)
unit_tests/test_quantum_hooks.py (+2/-1)
unit_tests/test_quantum_utils.py (+4/-2)
To merge this branch: bzr merge lp:~gnuoy/charms/trusty/quantum-gateway/conntrack
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+258350@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #4407 quantum-gateway-next for gnuoy mp258350
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/4407/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #4132 quantum-gateway-next for gnuoy mp258350
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/4132/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4006 quantum-gateway-next for gnuoy mp258350
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/4006/

Revision history for this message
James Page (james-page) :
review: Approve

Unmerged revisions

115. By Liam Young

Fix lint and unit tests

114. By Liam Young

conntrack needed for ha

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/quantum_utils.py'
2--- hooks/quantum_utils.py 2015-04-17 12:04:02 +0000
3+++ hooks/quantum_utils.py 2015-05-06 09:17:18 +0000
4@@ -182,7 +182,7 @@
5 },
6 }
7 LEGACY_RES_MAP = ['res_monitor']
8-L3HA_PACKAGES = ['keepalived']
9+L3HA_PACKAGES = ['keepalived', 'conntrack']
10
11 BASE_GIT_PACKAGES = [
12 'dnsmasq',
13
14=== modified file 'unit_tests/test_quantum_hooks.py'
15--- unit_tests/test_quantum_hooks.py 2015-04-10 14:22:04 +0000
16+++ unit_tests/test_quantum_hooks.py 2015-05-06 09:17:18 +0000
17@@ -339,7 +339,8 @@
18 def test_neutron_plugin_changed(self):
19 self.use_l3ha.return_value = True
20 self._call_hook('neutron-plugin-api-relation-changed')
21- self.apt_install.assert_called_with(['keepalived'], fatal=True)
22+ self.apt_install.assert_called_with(['keepalived', 'conntrack'],
23+ fatal=True)
24 self.assertTrue(self.CONFIGS.write_all.called)
25
26 def test_cluster_departed_nvp(self):
27
28=== modified file 'unit_tests/test_quantum_utils.py'
29--- unit_tests/test_quantum_utils.py 2015-04-23 08:14:44 +0000
30+++ unit_tests/test_quantum_utils.py 2015-05-06 09:17:18 +0000
31@@ -929,8 +929,10 @@
32 'start_dir': '/var/lib/neutron',
33 'process_name': 'neutron-nvsd-agent',
34 'executable_name': '/usr/local/bin/neutron-nvsd-agent',
35- 'config_files': ['/etc/neutron/neutron.conf',
36- '/etc/neutron/plugins/oneconvergence/nvsdplugin.ini'],
37+ 'config_files': [
38+ '/etc/neutron/neutron.conf',
39+ '/etc/neutron/plugins/oneconvergence/nvsdplugin.ini'
40+ ],
41 'log_file': '/var/log/neutron/nvsd-agent.log',
42 }
43 neutron_plugin_openflow_context = {

Subscribers

People subscribed via source and target branches