Merge lp:~gnuoy/charms/trusty/openvswitch-odl/tox into lp:~openstack-charmers-archive/charms/trusty/openvswitch-odl/next

Proposed by Liam Young on 2015-12-01
Status: Needs review
Proposed branch: lp:~gnuoy/charms/trusty/openvswitch-odl/tox
Merge into: lp:~openstack-charmers-archive/charms/trusty/openvswitch-odl/next
Diff against target: 19 lines (+2/-1)
1 file modified
Makefile (+2/-1)
To merge this branch: bzr merge lp:~gnuoy/charms/trusty/openvswitch-odl/tox
Reviewer Review Type Date Requested Status
OpenStack Charmers 2015-12-01 Pending
Review via email: mp+279126@code.launchpad.net
To post a comment you must log in.

charm_lint_check #14694 openvswitch-odl-next for gnuoy mp279126
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/14694/

charm_unit_test #13701 openvswitch-odl-next for gnuoy mp279126
    UNIT FAIL: unit-test missing

UNIT Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full unit test output: http://paste.ubuntu.com/13600109/
Build: http://10.245.162.77:8080/job/charm_unit_test/13701/

charm_amulet_test #8066 openvswitch-odl-next for gnuoy mp279126
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/13600412/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8066/

Unmerged revisions

7. By Liam Young on 2015-12-01

TOX ftw

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2015-11-16 08:33:32 +0000
3+++ Makefile 2015-12-01 14:45:52 +0000
4@@ -1,5 +1,6 @@
5 #!/usr/bin/make
6 PYTHON := /usr/bin/env python
7+TOX := /usr/bin/env tox
8
9 lint:
10 @flake8 --exclude hooks/charmhelpers,tests/charmhelpers \
11@@ -9,7 +10,7 @@
12 test:
13 @# Bundletester expects unit tests here.
14 @echo Starting tests...
15- @$(PYTHON) /usr/bin/nosetests -v --nologcapture --with-coverage unit_tests
16+ @$(TOX)
17
18 functional_test:
19 @echo Starting Amulet tests...

Subscribers

People subscribed via source and target branches

to all changes: