Merge lp:~gnuoy/charms/trusty/nova-compute/lp1506046 into lp:~openstack-charmers-archive/charms/trusty/nova-compute/next

Proposed by Liam Young
Status: Merged
Merged at revision: 176
Proposed branch: lp:~gnuoy/charms/trusty/nova-compute/lp1506046
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target: 22 lines (+2/-2)
2 files modified
hooks/nova_compute_utils.py (+1/-1)
templates/juno/nova.conf (+1/-1)
To merge this branch: bzr merge lp:~gnuoy/charms/trusty/nova-compute/lp1506046
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+274416@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #11895 nova-compute-next for gnuoy mp274416
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/11895/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #11063 nova-compute-next for gnuoy mp274416
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/11063/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7336 nova-compute-next for gnuoy mp274416
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12783201/
Build: http://10.245.162.77:8080/job/charm_amulet_test/7336/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Hi @gnuoy

This amulet fail is a scenario where things were just not quite ready when a test tried to do an operation.

I have a WIP helper to leverage extended status messages to confirm readiness before amulet tests proceed ... which I will be working like mad to squeeze into the next charm tests before the 15.10 push.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7374 nova-compute-next for gnuoy mp274416
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12796458/
Build: http://10.245.162.77:8080/job/charm_amulet_test/7374/

177. By Liam Young

Merged next in

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #12155 nova-compute-next for gnuoy mp274416
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/12155/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #11287 nova-compute-next for gnuoy mp274416
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/11287/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7426 nova-compute-next for gnuoy mp274416
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/7426/

Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/nova_compute_utils.py'
2--- hooks/nova_compute_utils.py 2015-10-06 16:58:22 +0000
3+++ hooks/nova_compute_utils.py 2015-10-19 06:58:53 +0000
4@@ -556,7 +556,7 @@
5 apt_upgrade(options=dpkg_opts, fatal=True, dist=True)
6 apt_install(determine_packages(), fatal=True)
7
8- # Regenerate configs in full for new release
9+ configs.set_release(openstack_release=new_os_rel)
10 configs.write_all()
11 [service_restart(s) for s in services()]
12
13
14=== modified file 'templates/juno/nova.conf'
15--- templates/juno/nova.conf 2015-10-08 21:38:25 +0000
16+++ templates/juno/nova.conf 2015-10-19 06:58:53 +0000
17@@ -1,4 +1,4 @@
18-# havana
19+# juno
20 ###############################################################################
21 # [ WARNING ]
22 # Configuration file maintained by Juju. Local changes may be overwritten.

Subscribers

People subscribed via source and target branches