Merge lp:~gnuoy/charms/trusty/keystone/restart-horror into lp:~openstack-charmers-archive/charms/trusty/keystone/next

Proposed by Liam Young
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~gnuoy/charms/trusty/keystone/restart-horror
Merge into: lp:~openstack-charmers-archive/charms/trusty/keystone/next
Diff against target: 46 lines (+12/-2)
3 files modified
hooks/config-changed (+9/-0)
hooks/keystone_hooks.py (+1/-1)
hooks/keystone_utils.py (+2/-1)
To merge this branch: bzr merge lp:~gnuoy/charms/trusty/keystone/restart-horror
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+274556@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

189. By Liam Young

Restart hook after upgrade

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified symlink 'hooks/config-changed' (properties changed: -x to +x)
2=== target was u'keystone_hooks.py'
3--- hooks/config-changed 1970-01-01 00:00:00 +0000
4+++ hooks/config-changed 2015-10-15 13:31:32 +0000
5@@ -0,0 +1,9 @@
6+#!/bin/bash
7+
8+./hooks/config-changed.real
9+RC=$?
10+if [[ $RC -eq 200 ]]; then
11+ ./hooks/config-changed.real
12+ RC=$?
13+fi
14+exit $RC
15
16=== modified file 'hooks/keystone_hooks.py'
17--- hooks/keystone_hooks.py 2015-10-08 22:29:33 +0000
18+++ hooks/keystone_hooks.py 2015-10-15 13:31:32 +0000
19@@ -129,7 +129,7 @@
20 git_install(config('openstack-origin-git'))
21
22
23-@hooks.hook('config-changed')
24+@hooks.hook('config-changed.real')
25 @restart_on_change(restart_map())
26 @synchronize_ca_if_changed(fatal=True)
27 def config_changed():
28
29=== modified file 'hooks/keystone_utils.py'
30--- hooks/keystone_utils.py 2015-10-06 19:19:34 +0000
31+++ hooks/keystone_utils.py 2015-10-15 13:31:32 +0000
32@@ -1,4 +1,5 @@
33 #!/usr/bin/python
34+import sys
35 import glob
36 import grp
37 import hashlib
38@@ -396,7 +397,7 @@
39 log("Database not ready - deferring to shared-db relation",
40 level=INFO)
41 return
42-
43+ sys.exit(200)
44
45 def is_db_initialised():
46 if relation_ids('cluster'):

Subscribers

People subscribed via source and target branches