Merge lp:~gnuoy/charms/precise/charmworld/install-pip into lp:~juju-jitsu/charms/precise/charmworld/trunk

Proposed by Liam Young
Status: Merged
Approved by: Brad Crittenden
Approved revision: 91
Merged at revision: 91
Proposed branch: lp:~gnuoy/charms/precise/charmworld/install-pip
Merge into: lp:~juju-jitsu/charms/precise/charmworld/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
hooks/install (+1/-1)
To merge this branch: bzr merge lp:~gnuoy/charms/precise/charmworld/install-pip
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email:

Description of the change

Pip is used in the charm hooks but not explicitly installed, so I've added it.

To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

Additional info: The IS basenode code turns off the default installation of recommended packages which is probably why this didn't show up earlier

Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for the patch and explanation Liam.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/install'
2--- hooks/install 2013-12-12 19:10:46 +0000
3+++ hooks/install 2014-03-17 14:05:28 +0000
4@@ -26,7 +26,7 @@
5 fi
6 DEBIAN_FRONTEND=noninteractive apt-get install -y \
7 bzr python-virtualenv python-dev python-dateutil python-cheetah \
8- charm-helper-sh build-essential postfix
9+ charm-helper-sh build-essential postfix python-pip
12 cp postfix/ /etc/postfix/


People subscribed via source and target branches

to all changes: