Code review comment for lp:~gnuoy/charms/precise/apache2/24-auth-format

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

This change LGTM +1. I tried this charm code on my environment with the upstream apache charm and also compared the results with this proposal adding the 'Require all denied' directive does the trick on apache 24 , the HTTP/1.1 403 Forbidden was replaced by a HTTP/1.1 200.

services:
  apache2-precise:
    charm: local:precise/apache2-0
    exposed: false
    units:
      apache2-precise/0:
        agent-state: started
        agent-version: 1.18.4.1
        machine: "3"
        open-ports:
        - 80/tcp
        - 443/tcp
        public-address: 10.0.3.106
  apache2-trusty:
    charm: local:trusty/apache2-1
    exposed: false
    units:
      apache2-trusty/0:
        agent-state: started
        agent-version: 1.18.4.1
        machine: "4"
        open-ports:
        - 80/tcp
        - 443/tcp
        public-address: 10.0.3.3

review: Approve

« Back to merge proposal