Merge lp:~gnuoy/charm-helpers/1595418 into lp:charm-helpers
Proposed by
Liam Young
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 592 | ||||
Proposed branch: | lp:~gnuoy/charm-helpers/1595418 | ||||
Merge into: | lp:charm-helpers | ||||
Diff against target: |
26 lines (+4/-3) 2 files modified
charmhelpers/core/hookenv.py (+1/-1) tests/core/test_hookenv.py (+3/-2) |
||||
To merge this branch: | bzr merge lp:~gnuoy/charm-helpers/1595418 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Page | Approve | ||
Review via email: mp+298200@code.launchpad.net |
To post a comment you must log in.
I always prefer to add the universal_ newlines= True argument to the subprocess calls, so they return proper strings. This seems preferable than faffing about with manual decoding and making the assumption that the system encoding is UTF-8. And fewer bytestrings infecting your tests.