Code review comment for lp:~gnumdk/libdbusmenu-qt/fix-dropdown-firefox

Revision history for this message
Charles Kerr (charlesk) wrote :

Well if we're going with that route, it would be better to test for #if defined(Q_WS_X11) ... CI is still going to fail with this new revision.

However since Mir and Wayland are gaining steam, I'd prefer if there was a fix that wasn't dependent on QX11Info. The Qt documentation for QX11AppInfo.appTime() only says "Returns the X11 time", so I'm not sure what the patch is doing.

Is there a portable alternative to using QX11AppInfo.appTime()?

« Back to merge proposal