bacce5e...
by
Matthew Leeds <email address hidden>
flatpak: Add app to be uninstalled to txn cache
This mirrors what we do for install operations, and ensures that the
GsApp object used by the GsFlatpakTransaction will be the same one which
was passed to gs_plugin_app_remove(), which prevents this warning:
(/builds/mwleeds/gnome-software/_build/plugins/flatpak/gs-self-test-flatpak:1689):
Gs-WARNING **: 21:05:06.803: application
user/flatpak/chiron1-origin/desktop/org.test.Chiron/master left in
removing helper
c0b9c4f...
by
Matthew Leeds <email address hidden>
flatpak: Don't use local checkout for flatpak cmd
Using a local checkout of flatpak at a hard-coded path for the 'flatpak'
command is of course bad for portability, but also bad because the
flatpak plugin might link against a different libflatpak (e.g. the
installed one).
fb2a1ac...
by
Matthew Leeds <email address hidden>
flatpak: Don't add NULL origin apps to cache
Currently we add all apps created by gs_flatpak_create_app() to the
cache (which is just a hash table). However if the origin is not set on
the app at the time we add it to the cache, its hash table key will have
a "*" for the origin, like
"user/flatpak/*/desktop/org.test.Chiron/master". Then if the origin is
later set to something, say "x", the app will still be returned from the
cache for a gs_plugin_cache_lookup() call with an ID specifying a
different origin, say "y". This can cause problems; we should be able to
assume that using the cache doesn't change the origin being used.
25978d3...
by
Matthew Leeds <email address hidden>
flatpak: Set app state to INSTALLED more consistently
In a couple places we were calling gs_flatpak_create_installed() but not
setting the app to AS_APP_STATE_INSTALLED. Fix that.
fe17e92...
by
Matthew Leeds <email address hidden>
flatpak: Properly catch remote not found errors
The error returned here changed in Flatpak 0.99.3, which is less than
our required version, so update it. This prevents the following message
when a flatpak bundle is opened:
not handling error not-supported for action refine: failed to get origin-hostname: Remote "flatpak" not found
9f98826...
by
Matthew Leeds <email address hidden>
gs-plugin-loader: Fix an outdated comment
MATCH_ANY_PREFIX was renamed to IS_WILDCARD in commit 8fe5566aa
Currently, every Flathub app is show as using a "legacy display manager"
whether they use x11 with --socket=x11, or wayland with
--socket=wayland and --socket=fallback-x11.
However, the fallback-x11 enables X11 only if the host doesn't support
anything else than x11, so strictly speaking, it's the host that uses
x11 and not usually the app.
So this commit stops from showing this warning if using x11 as fallback.
