gnome-maps:wip/mlundblad/search-entry-fixes

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

b987bab... by Marcus Lundblad <email address hidden> on 2023-01-17

placePopover: Remove unused import

Remove unused import for GTK.

de269e0... by Marcus Lundblad <email address hidden> on 2023-01-06

placeEntry: Implement key controller...

Re-implement the key controller handling
cursor keys and enter in the
search entries. This is based on the
result popovers not grabbing focus when shown.

b8386bf... by Marcus Lundblad <email address hidden> on 2023-01-10

placePopover, placeListRow: Use custom margins instead of libadwaita menu style

The "menu" style currently has the effect of not showing the selected item
in the GtkListBox, which makes selecting a result row with keyboard navigation
invisible.
https://gitlab.gnome.org/GNOME/libadwaita/-/issues/624

05e26e6... by Marcus Lundblad <email address hidden> on 2023-01-07

placePopover: Add public method to show a row

9fcf2b8... by Marcus Lundblad <email address hidden> on 2023-01-07

placePopover: Make list a public child

This will allow the search entry's key controller
to navigate the list and select items on arrow keys.

6db0e3b... by Marcus Lundblad <email address hidden> on 2023-01-07

searchPopover: Add getter for number of results

f32b99b... by Marcus Lundblad <email address hidden> on 2023-01-06

searchPopover: Remove key controller

Since the popover doesn't grab the focus
and the key controller to handle cursor
keys will be re-implemented on the search
entry.

b430db3... by Marcus Lundblad <email address hidden> on 2023-01-06

mainWindow: Select text when activating search shortcut

Select current text in search entry when activating search
via keyboard shortcut ctrl+f. This way starting typing will
automatically delete current text without having to manually
delete it.

ea4966e... by Marcus Lundblad <email address hidden> on 2023-01-06

placePopover: Set auto-hide to false

This avoids the popover to act as modal and grab keyboard focus.
The keyboard events will then continue to get routed to the
search entry when the popover is being shown.

344c0c6... by Marcus Lundblad <email address hidden> on 2023-01-09

mainWindow: Remove shortcuts for using bare +,=, and - for zooming

Supporting these (without modifier) causes issues when trying to type
in e.g. a place name containing a - in a place name in the search entry.
We used to have some workaround in the GTK 3 days, overriding the key-pressed
signal and filtering depending on the widget the event originated from to
support typing these characters into a search entry without triggering the
shortcut.
But this is not working anymore, and it seems to not be worth the effort
of trying to actually support this.
So we're probably better off dropping these. Can still support num pad
"add" and "subtract" keys still for zooming.