GNOME Maps

gnome-maps:wip/cdavis/post-port-cleanups

  1. Git
  2. lp:gnome-maps
  3. wip/cdavis/post-port-cleanups
Last commit made on 2022-08-26
Get this branch:
git clone -b wip/cdavis/post-port-cleanups https://git.launchpad.net/gnome-maps

Branch merges

Branch information

Name:
wip/cdavis/post-port-cleanups
Repository:
lp:gnome-maps

Recent commits

4e29e94... by Christopher Davis <email address hidden>

shape-layer-row: Modernize widget heirarchy

460091b... by Christopher Davis <email address hidden>

layersPopover: Use GMenuModel

When porting to GTK4 apps should stop using custom menu buttons
and instead use GMenuModel where possible. This commit
changes the shape layer menu to use GMenuModel with a custom
child for the list.

684a8e9... by Christopher Davis <email address hidden>

general: Use present() instead of show_all()

show_all() is gone in GTK4

3029bdb... by Christopher Davis <email address hidden>

placeListRow: Revamp widget heirarchy

Use a modern widget heirarchy that matches other applications.

f08049d... by Christopher Davis <email address hidden>

favoritesPopover: Use libadwaita popover styles

dcbb325... by Christopher Davis <email address hidden>

placePopover: Stop hardcoding height

Suggestion popovers should use the height of the entries
up to a certain point.

This commit removes the hardcoded height request and
sets a maximum height instead. This maximum value
is the same as the one from the Epiphany port.

6b33f62... by Christopher Davis <email address hidden>

css: Remove `.maps-popover` style class

This style class caused popovers to be aligned incorrectly.

2586483... by Christopher Davis <email address hidden>

placesPopover: Remove arrow

Suggestion popovers shouldn't have arrows. This commit
sets `has-arrow` to false uses CSS padding to get the
right spacing.

864bafa... by Christopher Davis <email address hidden>

placesPopover: Use libadwaita menu styles

04f5272... by Christopher Davis <email address hidden>

general: Rework context menu

The context menu had a few papercuts after the port, notably
placement. The code was also a bit hard to follow - the actions
were declared in mainWindow.js, but defined in contextMenu.js.

This commit removes the ContextMenu class, and instead builds
and displays the popover in mapView.js. This also allows
us to move our actions to mapView.js using a custom action group.
The placement is also fixed.