e21ef03...
by
Will Thompson <email address hidden>
keyboard: Warn if previewing keyboard fails
Previously, if tecla was not present, or there was some synchronous
error launching it, clicking Preview would silently do nothing. With
this change, there is at least a warning in the journal.
5383e8e...
by
Will Thompson <email address hidden>
goa: Simplify invoking helper synchronously
run_goa_helper_sync() is only used at one call site, which previously
did not handle the case where the command fails and the function returns
NULL. It would pass a NULL pointer to g_variant_parse(), which would
consequently return NULL without setting the error parameter, whereupon
the caller would dereference that NULL pointer.
Pass an error back to the caller; remove the unused argument handling;
and handle the case where the helper fails in the caller.
0d07160...
by
Will Thompson <email address hidden>
timezone: Squash a possibly-uninitialised warning
In the case where 'orientation' is not a valid member of the
GtkOrientation enum, it will be used uninitialised. I have to say I
don't find this particularly interesting, but my compiler feels
otherwise.
ba3e4da...
by
Will Thompson <email address hidden>
goa: Suppress a possibly-uninitialised warning
The compiler cannot know that, in practice, one or other of the X11 or
Wayland code paths will initialise 'display'. Initialise it to NULL,
then assert after the two conditionally-compiled blocks that it is not
NULL. We can all enjoy hitting that assertion when a third display
server protocol is invented.
904916d...
by
Will Thompson <email address hidden>
driver: Avoid unused variable with webkit < 2.39.5
This variable is only used if !WEBKIT_CHECK_VERSION(2, 39, 5) is true.
