gnome-calendar:mcatanzaro/rbz-1509551

Last commit made on 2019-07-03
Get this branch:
git clone -b mcatanzaro/rbz-1509551 https://git.launchpad.net/gnome-calendar

Branch merges

Branch information

Name:
mcatanzaro/rbz-1509551
Repository:
lp:gnome-calendar

Recent commits

d87152f... by Michael Catanzaro <email address hidden> on 2019-07-02

Try to fix a crash in update_default_calendar_row()

This function is crashing in 3.32 because the manager object is invalid.
I think there are two related bugs:

First, it looks like gcal_quick_add_popover_set_property() is failing to
disconnect its signals from the old GcalManager before setting the new
one. In one backtrace, I see the GcalManager emitting the signal is
different than the GcalQuickAddPopover's current manager, which is
surely unintended.

But that shouldn't be enough to crash on its own, since the
GcalQuickAddPopover should still have a valid manager, even if not the
intended one. So I suspect the GcalQuickAddPopover itself is invalid at
this point. (The crash occured for me after adding an event, so it was
probably just destroyed.) GcalQuickAddPopover is not disconnecting these
signals in dispose, which is unsafe. We can avoid the need to do so by
using g_signal_connect_object().

Now in master, the GcalManager is now owned indirectly by the GcalContext,
but the underlying problems from the 3.32 crash are all still here. This
attempts to fix them. The fix is speculative, but it's surely safer than
the original code.

Fixes #416, fixes #418, fixes #420, and fixes #392. Probably fixes a lot
more. Who knows.

https://bugzilla.redhat.com/show_bug.cgi?id=1509551

008055b... by Fabio Tomat <email address hidden> on 2019-06-30

Update Friulian translation

0b41193... by Georges Basile Stavracas Neto on 2019-06-26

month-view: Use last cell to calculate multday event end

Instead of assuming all cells have the same width, use the last
cell to figure out the width of the event with the traditional:

    event width = end.x2 - start.x1
    event width = (end.x1 + end.width) - start.x1

https://gitlab.gnome.org/GNOME/gnome-calendar/issues/413

c1653f1... by Rafael Fontenelle on 2019-06-26

Update Brazilian Portuguese translation

88121f5... by Daniel Mustieles on 2019-06-26

Updated Spanish translation

f486f76... by Piotr Drąg on 2019-06-25

Update POTFILES.in

33fc75c... by Georges Basile Stavracas Neto on 2019-06-25

calendar-management-page: Pass GcalCalendar

47bed7b... by Georges Basile Stavracas Neto on 2019-06-25

new-calendar-page: Restore opening Online Accounts panel from label

a95097f... by Georges Basile Stavracas Neto on 2019-06-25

calendar-management-dialog: Remove unused signal handler

4a75363... by Georges Basile Stavracas Neto on 2019-06-25

new-calendar-page: Add more file filters