gnome-calculator:wip/3v1n0/coverage

Last commit made on 2018-09-11
Get this branch:
git clone -b wip/3v1n0/coverage https://git.launchpad.net/gnome-calculator

Branch merges

Branch information

Name:
wip/3v1n0/coverage
Repository:
lp:gnome-calculator

Recent commits

7e65af7... by Marco Trevisan (Treviño)

gitlab-ci: enable coverage reports

d0d8b2e... by Marco Trevisan (Treviño)

gitlab-ci: only keep build artifacts for 2 hours

Since the test timeout is set to 1 hour, we are sure that these
will be kept enough for the test job to be ran, even in case
of mayor delays.

1cb3c20... by Marco Trevisan (Treviño)

gitlab-ci: also build snap package

aa23f30... by Marco Trevisan (Treviño)

gitlab-ci: run tests after building

e3ca208... by Marco Trevisan (Treviño)

search-provider: Handle errors gracefully

Instead of exiting immediately if a spawn error occurred, inform our dbus
client about it with a proper spawn error.

As bonus, get rid of the compile warning.

15d0716... by Marco Trevisan (Treviño)

search-provider: cache only a limited number of equations

2bd8ecb... by Marco Trevisan (Treviño)

search-provider: cache equations avoiding spawning calculator twice

Currently we spawn the calculator two times for each operation, one to check
if the search provider is valid for such syntax, the other time to actually
present the results. But since these results are just available at first
call, we can just keep them around and return them if the shell requires them.

Since the search provider deamon is kept alive for just few moments, there's
no real need to cleanup the cache using a queue.

In case of multiple async calls, reuse cancellable instead so that we can
just kill all the related processes one time at once.

882d2f5... by Marco Trevisan (Treviño)

search-provider: cancel the current process on new calculation request

As there's just one shell running at time, there's no point of supporting
parallel calls, we can just safely refer to the last equation as the only one
we need to compute.

cffdf4c... by Marco Trevisan (Treviño)

search-provider: simplify solve_subprocess

Only return a subprocess in solve_subprocess and make the callers deal with
the actual operation to perform.

da4ea8c... by Marco Trevisan (Treviño)

search-provider: Use lower inactivity timeout

Since we're renewing it at every call involving a process call, we can just
set it to a lower value than the default dbus proxy timeout, so that the provider
will return invalid values before that the timeout has been hit.