~gnome3-team/epiphany-browser/+git/master:mcatanzaro/coverity-gnome-42

Last commit made on 2023-01-04
Get this branch:
git clone -b mcatanzaro/coverity-gnome-42 https://git.launchpad.net/~gnome3-team/epiphany-browser/+git/master

Branch merges

Branch information

Name:
mcatanzaro/coverity-gnome-42
Repository:
lp:~gnome3-team/epiphany-browser/+git/master

Recent commits

54849c4... by Michael Catanzaro <email address hidden>

embed-prefs: fix double free on error path

If we fail to create the file monitor for the user JS file, then we free
the error twice by mistake. Uh-oh. Found by Coverity.

a311325... by =?utf-8?q?J=C3=BCrgen_Benvenuti?= <email address hidden>

Update German translation

07daea3... by Charles Monzat <email address hidden>

Update French translation

89fb934... by Zurab Kargareteli <email address hidden>

Update Georgian translation

e264790... by Aleksandr Melman <email address hidden>

Update Russian translation

e7d53b1... by Carlos Garcia Campos <email address hidden>

web-app: do not show the search suggestions settings in web app mode

Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1178>

(cherry picked from commit 8d5130cb13fb9a0609ce6c9f7b826fcbc260df28)

a904a30... by Michael Catanzaro <email address hidden>

Prepare 42.4

801e6d2... by Bartłomiej Piotrowski

Update (or drop) the Docker image used by Flatpak job

The gnome-runtime-images have been recently migrated to Quay. This is already reflected in the template.

Please note this MR has been created semi-automatically. If it doesn't make sense, feel free to close it.

130f25b... by Michael Catanzaro <email address hidden>

window-commands: work around GTK native dialog hang

When importing bookmarks, we have:

 (1) EphyWindow, transient parent of
 (2) GtkDialog to select where to import bookmarks from, transient
parent of
 (3) The native file chooser dialog (in case of GVDB or HTML import)

Sadly, opening a native dialog on a modal dialog hangs the application,
gtk#5011. To dodge this problem, we can close the second dialog
dialog when opening the third dialog, and make the EphyWindow the
transient parent of the third dialog. This is inconvenient because it
means you're all the way back to step one if you decide to cancel the
third dialog and want to go back to the second dialog, but it's better
than a hang.

Exporting bookmarks does not have this problem, because there we skip
step 2.

Importing passwords does not have this problem, because there we don't
have a native file chooser. (At least, I think so. Didn't test this
because I do not have Chrome installed.)

(cherry picked from commit 4b1e57d4b2b950ae4f52b6ca383af9b7d41a5aa7)

4e0865b... by Michael Catanzaro <email address hidden>

Fix crashes and misbehavior when importing bookmarks

We are trying to use the index of the selected item to decide what
action to perform, but this doesn't work because not all items are
actually present in the combo box. E.g. if there is no Firefox profile,
it won't be present in the list. This causes the wrong codepath to be
selected. In this bug report, the user complains that it crashes due to
not finding any Firefox profiles when importing bookmarks from Chrome.

Fixes #1800

(cherry picked from commit a22f87c895ee36b7a7905a91ac181d0a6522170f)