~gnome-shell-extensions/gnome-shell-extensions/+git/gnome-shell-notifications-alert:3.4

Last commit made on 2012-10-26
Get this branch:
git clone -b 3.4 https://git.launchpad.net/~gnome-shell-extensions/gnome-shell-extensions/+git/gnome-shell-notifications-alert

Branch merges

Recent commits

93e1948... by Thiago Bellini

Clarify on description that now it 'blinks'.

52bee19... by Thiago Bellini

Prevent a race condition and always remove message style

fc6098c... by Thiago Bellini

Support gnome 3.4.2 too

5f9cdd8... by Thiago Bellini

Be more explicative on blink label

The user needs to know that the option is in ms even without
reading the tooltip.

b1aff00... by Thiago Bellini

Update description. Add some parts ego removed

eb3b95f... by Thiago Bellini

Call _loopStyle after setting _hasStyleAdded

Call _loopStyle after setting _hasStyleAdded or else the first notification
may not get alerted (problem discovered testing on 3.6).

6e8f067... by Thiago Bellini

Prevent some race conditions

Prevent 2 race conditions that could ocour when changing blinkrate from
something to 0 and from 0 to something:
* Only cache _oldStyle if it's different than SETTING_COLOR. Maybe it stopped
  looping when the style was added.
* If we are not looping, be sure to set the style to SETTING_COLOR. This could
  make it as the oldStyle when notifications added while changing blinkrate.
  Needed to invert the toogle logic for that too.

0b4baf1... by Thiago Bellini

Add a setting for configuring blink rate

53f2500... by Thiago Bellini

Prevent a possible race condition

On timeout, maybe style was removed and them added. In that case, the loopStyle
for that timeout will still be running and another will start. None of them
will stop since _hasStyleAdded is true now. Removing the timeout source before
removing the style seems to do the trick.

3ad3075... by Thiago Bellini

Some code corrections

* Compare using loopDelay > 0 instead of 0 < loopDelay. It's easier to
  understand this way.
* Remove some trailing whitespaces.