Merge lp:~gmdduf/linaro-image-tools/gauss-support into lp:linaro-image-tools/11.11

Proposed by Bernard Park
Status: Needs review
Proposed branch: lp:~gmdduf/linaro-image-tools/gauss-support
Merge into: lp:linaro-image-tools/11.11
Diff against target: 45 lines (+16/-1)
2 files modified
linaro_image_tools/media_create/boards.py (+16/-0)
linaro_image_tools/media_create/tests/test_media_create.py (+0/-1)
To merge this branch: bzr merge lp:~gmdduf/linaro-image-tools/gauss-support
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Needs Fixing
Review via email: mp+164610@code.launchpad.net

Description of the change

this patch support Samsung Gauss server platform

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Hi,

thanks for working on this.
There are a couple of errors that would need fixing:

./linaro_image_tools/media_create/boards.py:1692:1: E302 expected 2 blank lines, found 1
./linaro_image_tools/media_create/boards.py:1702:26: E222 multiple spaces after operator
./linaro_image_tools/media_create/boards.py:1705:26: E222 multiple spaces after operator
./linaro_image_tools/media_create/tests/test_media_create.py:1558:1: E302 expected 2 blank lines, found 1

Those were found running the tests locally.
Also, is it possible for you to add some simple test for the new board? You can take a look at linaro_image_tools/media_create/tests/test_media_create.py, and look for a board like HighBank. The tests basically can be pretty much the same.

Thanks.

review: Needs Fixing
Revision history for this message
Milo Casagrande (milo) wrote :

Hi,

we are going to release Linaro Image Tools this week, would you like this to land with the 13.05 release? I can easily fix those errors in case.

Unmerged revisions

623. By Bernard Park

gauss support fix

622. By Bernard Park

gauss support

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro_image_tools/media_create/boards.py'
2--- linaro_image_tools/media_create/boards.py 2013-04-04 08:12:38 +0000
3+++ linaro_image_tools/media_create/boards.py 2013-05-19 07:47:27 +0000
4@@ -1689,6 +1689,21 @@
5 bl0_file = os.path.join(chroot_dir, self.bl0_file)
6 return bl0_file
7
8+class GaussConfig(BoardConfig):
9+ def __init__(self):
10+ super(GaussConfig, self).__init__()
11+ self.boot_script = 'boot.scr'
12+ self.bootloader_flavor = 'gauss'
13+ self.kernel_flavors = ['gauss']
14+ self.serial_tty = 'ttySAC0'
15+ self.fatload_command = 'ext2load'
16+ self.load_interface = 'sata'
17+ self.bootfs_type = 'ext2'
18+ self.dtb_addr = '0x81f00000'
19+ self.initrd_addr = '0x82000000'
20+ self.kernel_addr = '0x80007000'
21+ self.load_addr = '0x80008000'
22+
23
24 class HighBankConfig(BoardConfig):
25 def __init__(self):
26@@ -1777,6 +1792,7 @@
27 'efikamx': EfikamxConfig,
28 'efikasb': EfikasbConfig,
29 'fastmodel': FastModelConfig,
30+ 'gauss': GaussConfig,
31 'highbank': HighBankConfig,
32 'i386': I386Config,
33 'igep': IgepConfig,
34
35=== modified file 'linaro_image_tools/media_create/tests/test_media_create.py'
36--- linaro_image_tools/media_create/tests/test_media_create.py 2013-04-04 08:12:38 +0000
37+++ linaro_image_tools/media_create/tests/test_media_create.py 2013-05-19 07:47:27 +0000
38@@ -1555,7 +1555,6 @@
39 expected = []
40 self.assertEqual(expected, self.funcs_calls)
41
42-
43 class TestPopulateRawPartitionAndroid(TestCaseWithFixtures):
44
45 def setUp(self):

Subscribers

People subscribed via source and target branches