Code review comment for lp:~gmb/maas/fix-my-stupidity

Revision history for this message
Graham Binns (gmb) wrote :

> Yup, that should do it. Maybe make_ip_range should take a "minimum size"
> argument, too, but that would be harder to implement I suppose.

Yeah.

> By the way, clean_ip_ranges looks as if it could be a lot prettier if it just
> started with "if I have nothing to do here, return right away."

Agreed. I'll change that as a drive-by.

« Back to merge proposal