Code review comment for lp:~gmb/maas/fix-my-stupidity

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Yup, that should do it. Maybe make_ip_range should take a "minimum size" argument, too, but that would be harder to implement I suppose.

By the way, clean_ip_ranges looks as if it could be a lot prettier if it just started with "if I have nothing to do here, return right away."

review: Approve

« Back to merge proposal