Merge lp:~gmb/maas-test/fix-bug-1266996 into lp:maas-test

Proposed by Graham Binns
Status: Merged
Approved by: Graham Binns
Approved revision: 102
Merged at revision: 102
Proposed branch: lp:~gmb/maas-test/fix-bug-1266996
Merge into: lp:maas-test
Diff against target: 12 lines (+1/-1)
1 file modified
maastest/main.py (+1/-1)
To merge this branch: bzr merge lp:~gmb/maas-test/fix-bug-1266996
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+200801@code.launchpad.net

Commit message

Fix bug 1266996 by making sure we're using CachingOutputStream correctly.

Description of the change

This branch fixes bug 126696 by making sure that we're using CachingOutputStream correctly.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Ah yes, that would explain the errors I suppose.

I don't suppose this could be extracted into a testable function, so we can catch future regressions?

review: Approve
Revision history for this message
Graham Binns (gmb) wrote :

Yes, it can be, I think. The whole of main.py needs some testing love though, so we'll do that elsewhere.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'maastest/main.py'
2--- maastest/main.py 2014-01-06 07:53:25 +0000
3+++ maastest/main.py 2014-01-08 10:34:05 +0000
4@@ -97,7 +97,7 @@
5 raise
6 from maastest import report
7 encoded_results = (
8- output_stream.buffer.getvalue().encode('utf-8'))
9+ output_stream.cache.getvalue().encode('utf-8'))
10 if not args.no_reporting:
11 report.report_test_results(
12 encoded_results, log_only=args.log_results_only)

Subscribers

People subscribed via source and target branches