Merge lp:~gmb/launchpad/subscribe-using-api-bug-697619 into lp:launchpad

[Graham Binns]

[r=allenap][ui=none][bug=697619]

This branch fixes bug 697619 by making the new subscribe widget fire a
subscriptionwizard:save event when its form is submitted. In a
subsequent branch we'll use this event to hook the new widget up to the
existing subscription functionality.

[Gavin Panella (allenap)]

Nice, I'm learning stuff :)

[1]

+ var submit_button =

Trailing whitespace.

[2]

+ Assert.isTrue(subscriptionwizard_save_fired);

Is it worth putting this after the call to show_wizard()? If the
subscriptionwizard:ready event is, say, renamed or removed, the
handler will never be fired, and the assertion never made.

review: Approve

[Gavin Panella (allenap)]

[3]

- fetchCSS: false
+ fetchCSS: true,

Btw, what does this do?

[Graham Binns (gmb)]

> Nice, I'm learning stuff :)
>
>
> [1]
>
> + var submit_button =
>
> Trailing whitespace.
>

Arse. Fixed.

>
> [2]
>
> + Assert.isTrue(subscriptionwizard_save_fired);
>
> Is it worth putting this after the call to show_wizard()? If the
> subscriptionwizard:ready event is, say, renamed or removed, the
> handler will never be fired, and the assertion never made.

You're right. I originally moved it because I thought that asynchronicity was causing me problems. I've moved it back.

[Graham Binns (gmb)]

> [3]
>
> - fetchCSS: false
> + fetchCSS: true,
>
> Btw, what does this do?

It makes the CSS for the test page Not Suck. It shouldn't be committed though (and I've removed it) because it causes CSS to be fetched from elsewhere, and IIRC that will cause problems with the test runner.

=== modified file 'lib/lp/bugs/javascript/bug_subscription_widget.js'
--- lib/lp/bugs/javascript/bug_subscription_widget.js	2010-12-14 10:42:45 +0000
+++ lib/lp/bugs/javascript/bug_subscription_widget.js	2011-01-06 13:22:30 +0000
@@ -39,6 +39,11 @@
         steps: wizard_steps
     });
     namespace.subscription_wizard.render('#subscribe-wizard');
+    namespace.subscription_wizard.form_node.on(
+        'submit', Y.bind(function(e) {
+            e.preventDefault();
+            Y.fire('subscriptionwizard:save');
+        }));
     Y.fire('subscriptionwizard:ready');
 };
 

=== modified file 'lib/lp/bugs/javascript/tests/test_bug_subscription_widget.js'
--- lib/lp/bugs/javascript/tests/test_bug_subscription_widget.js	2010-12-14 10:42:45 +0000
+++ lib/lp/bugs/javascript/tests/test_bug_subscription_widget.js	2011-01-06 13:22:30 +0000
@@ -4,7 +4,7 @@
     base: '../../../../canonical/launchpad/icing/yui/',
     filter: 'raw',
     combine: false,
-    fetchCSS: false
+    fetchCSS: false,
     }).use(
         'event', 'event-simulate', 'lazr.testing.mockio',
         'lp.bugs.bug_subscription_wizard', 'node', 'test',
@@ -263,6 +263,30 @@
             subscribe_form_body,
             subscription_wizard.get('steps')[0].get('form_content'));
         Assert.isTrue(subscription_wizard.get('visible'));
+    },
+
+    test_submitting_wizard_form_fires_event: function() {
+        // When the wizard form is submitted, a
+        // subscriptionwizard:save event is fired.
+        var subscriptionwizard_save_fired = false;
+        Y.on(
+            'subscriptionwizard:save',
+            Y.bind(function(e) { subscriptionwizard_save_fired = true; }));
+        Y.on(
+            'subscriptionwizard:ready',
+            Y.bind(function(e) {
+                var subscription_wizard =
+                    Y.lp.bugs.bug_subscription_wizard.subscription_wizard;
+                var submit_button =
+                    Y.one('input[type=submit]');
+                Y.Event.simulate(Y.Node.getDOMNode(submit_button), 'click');
+            }));
+
+        Y.lp.bugs.bug_subscription_wizard.initialize_subscription_wizard(
+            subscribe_node, 'http://example.com', mock_io);
+        mock_io.simulateXhr(success_response, false);
+        Y.lp.bugs.bug_subscription_wizard.show_wizard();
+        Assert.isTrue(subscriptionwizard_save_fired);
     }
 }));