Merge lp:~gmb/launchpad/remove-bug-heat-from-garbo-daily-bug-511283 into lp:launchpad/db-devel
| Status: | Merged |
|---|---|
| Approved by: | Graham Binns on 2010-01-22 |
| Approved revision: | not available |
| Merged at revision: | not available |
| Proposed branch: | lp:~gmb/launchpad/remove-bug-heat-from-garbo-daily-bug-511283 |
| Merge into: | lp:launchpad/db-devel |
| Diff against target: |
11 lines (+0/-1) 1 file modified
lib/canonical/launchpad/scripts/garbo.py (+0/-1) |
| To merge this branch: | bzr merge lp:~gmb/launchpad/remove-bug-heat-from-garbo-daily-bug-511283 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Poster (community) | release-critical | 2010-01-25 | Approve on 2010-01-25 |
| Gavin Panella (community) | code | 2010-01-22 | Approve on 2010-01-22 |
|
Review via email:
|
|||
Commit Message
BugHeatUpdater is no longer run as part of garbo-daily.
| Graham Binns (gmb) wrote : | # |
| Graham Binns (gmb) wrote : | # |
I've requested a release-critical for this branch since without it there's a good chance that garbo-daily will take well over 30 hours to run after the rollout. That's not so clever an attribute in a daily script.
Note that this would have landed on Friday but for unrelated buildbot failures.
| Graham Binns (gmb) wrote : | # |
Also note that no tests have been changed; due to the nature of the garbo tests that was unnecessary.
| Gary Poster (gary) wrote : | # |
Hi Graham. I'm trying for the guideline of "if it would have been a CP, it can be a release-critical". The problem you say it addresses does sound like it would be a CP candidate under non-release circumstances, but could you verify before I pursue further?
| Gary Poster (gary) wrote : | # |
Graham verified that this is a CP-equivalent, and gave a few more details.

Don't run BugHeatUpdater as part of garbo-daily.