Merge lp:~gmb/launchpad/non-js-muting-bug-734732 into lp:launchpad
Proposed by
Graham Binns
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 12624 | ||||
Proposed branch: | lp:~gmb/launchpad/non-js-muting-bug-734732 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
170 lines (+110/-3) 5 files modified
lib/lp/bugs/browser/bug.py (+1/-3) lib/lp/bugs/browser/bugsubscription.py (+34/-0) lib/lp/bugs/browser/configure.zcml (+6/-0) lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+37/-0) lib/lp/bugs/templates/bug-mute.pt (+32/-0) |
||||
To merge this branch: | bzr merge lp:~gmb/launchpad/non-js-muting-bug-734732 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+53981@code.launchpad.net |
Commit message
[r=bac][bug=734732] There is now a non-JS process for muting mail from a bug.
Description of the change
This branch adds a BugTask:+mute view, so that stick-in-the muds who use
console-based browsers (RMS, I'm looking at you here) and people who use
browsers that don't play nice with YUI 3 (IE, now I'm looking at you)
can still use the mute / unmute functionality.
The +mute view presents a single button that allows the user to mute or
unmute bug mail for a bug. If the +mute page is visited by a user who
already holds a mute on the bug, they'll be redirected to the +subscribe
page, which handles the unmuting (and resubscribing if desired) story.
To post a comment you must log in.
Looks good, Graham, nice and simple.
I have a few issues:
1) You are inconsistent in text presented to the user of "mail" vs. "email" but definitely not "e-mail".
2) The phrase "Bug mail for bug X" is wordy. s/Bug mail/Mail or Email.
3) In test_bug_ mute_self_ view_mutes_ bug it would be nice to see the user is not muted before you exercise the form.