Merge lp:~gmb/launchpad/inline-help-for-bugwatches-2-bug-530162 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Abel Deuring | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 10906 | ||||
Proposed branch: | lp:~gmb/launchpad/inline-help-for-bugwatches-2-bug-530162 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
497 lines (+289/-76) 9 files modified
lib/lp/bugs/browser/bugtask.py (+61/-2) lib/lp/bugs/browser/configure.zcml (+3/-0) lib/lp/bugs/configure.zcml (+0/-1) lib/lp/bugs/interfaces/bugwatch.py (+0/-3) lib/lp/bugs/model/bugwatch.py (+0/-47) lib/lp/bugs/stories/bugwatches/xx-bugwatch-errors.txt (+23/-16) lib/lp/bugs/templates/bugtask-edit-form.pt (+9/-3) lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt (+8/-4) lib/lp/bugs/templates/bugwatch-error-help.pt (+185/-0) |
||||
To merge this branch: | bzr merge lp:~gmb/launchpad/inline-help-for-bugwatches-2-bug-530162 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Matthew Revell (community) | help | Approve | |
Review via email: mp+25784@code.launchpad.net |
Commit message
Popup help has been added for BugWatch errors.
Description of the change
This branch adds inline help for bug watch errors. The idea is that users should be able to fix bug watch error problems themselves (where possible) rather than just being presented with an opaque error.
I've made the following changes:
== lib/lp/
- I've added a mixin class that can be used by views that display bugwatch error data. This has a single property, bug_watch_
== lib/lp/
- I've added the necessary ZCML for the BugWatch +error-help view.
== lib/lp/
- I've removed getLastErrorMes
== lib/lp/
- I've removed the declaration of IBugWatch.
== lib/lp/
- I've removed the implementation of BugWatch.
== lib/lp/
- I've added popup help to the warning icon that appears when a BugWatch has failed to update.
== lib/lp/
- I've added a popup help link to the error message that appears when a BugWatch has failed to update.
== lib/lp/
- I've added help for the various different types of error that a BugWatch could encounter.
=== lib/lp/
- I've updated the story to take account of the popup help links.
+1 on the help pop-up text and great work on creating a dynamic help pop-up.
Small typo:
"The remote bug ID that the bug watch is linked it isn't valid on the remote bug tracker."
Should that be "...is linked to..." ?