Merge lp:~gmb/launchpad/inline-help-for-bugwatches-2-bug-530162 into lp:launchpad
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Abel Deuring on 2010-05-21 | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 10906 | ||||
| Proposed branch: | lp:~gmb/launchpad/inline-help-for-bugwatches-2-bug-530162 | ||||
| Merge into: | lp:launchpad | ||||
| Diff against target: |
497 lines (+289/-76) 9 files modified
lib/lp/bugs/browser/bugtask.py (+61/-2) lib/lp/bugs/browser/configure.zcml (+3/-0) lib/lp/bugs/configure.zcml (+0/-1) lib/lp/bugs/interfaces/bugwatch.py (+0/-3) lib/lp/bugs/model/bugwatch.py (+0/-47) lib/lp/bugs/stories/bugwatches/xx-bugwatch-errors.txt (+23/-16) lib/lp/bugs/templates/bugtask-edit-form.pt (+9/-3) lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt (+8/-4) lib/lp/bugs/templates/bugwatch-error-help.pt (+185/-0) |
||||
| To merge this branch: | bzr merge lp:~gmb/launchpad/inline-help-for-bugwatches-2-bug-530162 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Abel Deuring (community) | code | 2010-05-21 | Approve on 2010-05-21 |
| Matthew Revell (community) | help | Approve on 2010-05-21 | |
|
Review via email:
|
|||
Commit Message
Popup help has been added for BugWatch errors.
Description of the Change
This branch adds inline help for bug watch errors. The idea is that users should be able to fix bug watch error problems themselves (where possible) rather than just being presented with an opaque error.
I've made the following changes:
== lib/lp/
- I've added a mixin class that can be used by views that display bugwatch error data. This has a single property, bug_watch_
== lib/lp/
- I've added the necessary ZCML for the BugWatch +error-help view.
== lib/lp/
- I've removed getLastErrorMes
== lib/lp/
- I've removed the declaration of IBugWatch.
== lib/lp/
- I've removed the implementation of BugWatch.
== lib/lp/
- I've added popup help to the warning icon that appears when a BugWatch has failed to update.
== lib/lp/
- I've added a popup help link to the error message that appears when a BugWatch has failed to update.
== lib/lp/
- I've added help for the various different types of error that a BugWatch could encounter.
=== lib/lp/
- I've updated the story to take account of the popup help links.
| Abel Deuring (adeuring) wrote : | # |
/lp/bugs/
> --- lib/lp/
> +++ lib/lp/
> @@ -0,0 +1,182 @@
> +<html>
> + <head>
> + <title>Bug watch errors</title>
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + </head>
> + <body tal:define="watch view/context">
> + <h1>Bug watch update errors</h1>
> + <p>
> + Bug watches don't always update successfully. When a bug watch
> + fails to update, Launchpad records what went wrong.
> + </p>
> + <a name="UNKNOWN"></a>
> + <h2>Unknown error</h2>
> + <h3>What went wrong?</h3>
> + <p>
> + Launchpad encountered an unexpected error when trying to retrieve
> + the bug from the remote server.
> + </p>
> + <h3>How can I help fix it?</h3>
> + <p>
> + <a href="mailto:<email address hidden>">Contact us</a> and let us
> + know about the problem.
> + </p>
> + <a name="BUG_
> + <h2>Bug Not Found</h2>
> + <h3>What went wrong?</h3>
> + <p>
> + Launchpad could not find the specified bug on the remote server.
> + </p>
> + <h3>How can I help fix it?</h3>
> + <p>
> + Check that the remote bug
> + (<a tal:replace=
> + exists on the external bug tracker. If it doesn't, you should try
> + to find the correct bug and
> + <a tal:attributes=
> + that it points to the correct remote bug.
> + </p>
> + <a name="CONNECTIO
> + <h2>Connection Error</h2>
> + <h3>What went wrong?</h3>
> + <p>
> + Launchpad was unable to connect to the remote server.
> + </p>
> + <h3>How can I help fix it?</h3>
> + <p>
> + Check that the remote bug tracker
> + (<a tal:replace=
> + is on-line. If it is, you should
> + <a href="mailto:<email address hidden>">contact us</a> and let us
> + know about the problem.
> + </p>
> + <a name="INVALID_
> + <h2>Invalid Bug ID</h2>
> + <h3>What went wrong?</h3>
> + <p>
> + The remote bug ID that the bug watch is linked it isn't valid on
> + the remote bug tracker.
> + </p>
> + <h3>How can I help fix it?</h3>
> + <p>
> + <a href="mailto:<email address hidden>">Contact us</a> and let us
...know about the problem
> + </p>
> + <a name="TIMEOUT"></a>
> + <h2>Timeout</h2>
> + <h3>What went wrong?</h3>
> + <p>
> + Launchpad encountered a timeout when trying to connect to the
> + remote server and was unable to retrieve the bug's status.
> + </p>
> + <h3>How can I help fix it?</h3>
> + <p>
> + <a href="mailto:<email address hidden>">Contact us</a> and let us
...know about the problem
> + </p>
> + <p>
> + Check that the remote b...

+1 on the help pop-up text and great work on creating a dynamic help pop-up.
Small typo:
"The remote bug ID that the bug watch is linked it isn't valid on the remote bug tracker."
Should that be "...is linked to..." ?