Merge lp:~gmb/launchpad/fix-ff-for-ss-bug-677020 into lp:launchpad
Proposed by
Graham Binns
Status: | Merged |
---|---|
Merged at revision: | 11945 |
Proposed branch: | lp:~gmb/launchpad/fix-ff-for-ss-bug-677020 |
Merge into: | lp:launchpad |
Diff against target: |
50 lines (+17/-5) 2 files modified
lib/lp/bugs/browser/bugsubscription.py (+6/-5) lib/lp/registry/browser/tests/test_structuralsubscription.py (+11/-0) |
To merge this branch: | bzr merge lp:~gmb/launchpad/fix-ff-for-ss-bug-677020 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+41187@code.launchpad.net |
Commit message
[r=adeuring]
Description of the change
This branch ensures that the feature-flagging of the advanced subscriptions features works for the structural subscriptions form by adding a check for the feature flag to AdvancedSubscri
To post a comment you must log in.
(17:24:50) abel: gmb: looks fine -- but what I don't understand is this: BugSubscription SubscribeSelfVi ew.setUpFields( ) already calls _seUpBugNotific ationLevelFiled only if the feature is enabled. Or am I missing something? SubscribeSelfVi ew that's the problem, but I get your point. I'll remove that condition (the idea of my change is that whoever is using AdvancedSubscri ptionMixin shouldn't have to remember to add the conditional in the first place.)
(17:25:39) gmb: abel: It's not BugSubscription
(17:26:09) abel: gmb: ah, OK, I see. so, r=me