Merge lp:~gmb/launchpad/filter-on-bug-creation-bug-720147 into lp:launchpad

[Graham Binns]

[r=benji][ui=none] [r=benji][bug=720147] Users that have BugSubscriptionFilters on bug status and importance should no longer receive creation notifications about bugs that don't match those filters.

This branch fixes the test failures encountered in lp:~bac/launchpad/bug-720147. These failures occurred because our tests rely on the internal API allowing them to set initial BugTask statuses without any permission checks. Whilst this is probably a bit silly it's safeguarded by the WS API and the LP UI, so I see no harm in reverting the change here for the time being.

[Benji York (benji)]

Looks good.

review: Approve (code)

=== modified file 'lib/lp/bugs/model/bug.py'
--- lib/lp/bugs/model/bug.py	2011-05-03 12:46:08 +0000
+++ lib/lp/bugs/model/bug.py	2011-05-03 12:46:11 +0000
@@ -2443,20 +2443,19 @@
         # Create the task on a product if one was passed.
         if params.product:
             getUtility(IBugTaskSet).createTask(
-                bug=bug, product=params.product, owner=params.owner)
+                bug=bug, product=params.product, owner=params.owner,
+                status=params.status)
 
         # Create the task on a source package name if one was passed.
         if params.distribution:
             getUtility(IBugTaskSet).createTask(
                 bug=bug, distribution=params.distribution,
                 sourcepackagename=params.sourcepackagename,
-                owner=params.owner)
+                owner=params.owner, status=params.status)
 
         bug_task = bug.default_bugtask
         if params.assignee:
             bug_task.transitionToAssignee(params.assignee)
-        if params.status:
-            bug_task.transitionToStatus(params.status, params.owner)
         if params.importance:
             bug_task.transitionToImportance(params.importance, params.owner)
         if params.milestone: