Merge lp:~gmb/launchpad/expose-level-bug-704685 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Данило Шеган | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12272 | ||||
Proposed branch: | lp:~gmb/launchpad/expose-level-bug-704685 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
154 lines (+54/-8) 5 files modified
lib/canonical/launchpad/components/apihelpers.py (+15/-0) lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+5/-0) lib/lp/bugs/interfaces/bug.py (+8/-1) lib/lp/bugs/interfaces/bugsubscription.py (+9/-7) lib/lp/bugs/stories/webservice/xx-bug.txt (+17/-0) |
||||
To merge this branch: | bzr merge lp:~gmb/launchpad/expose-level-bug-704685 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | code | Approve | |
Review via email: mp+46829@code.launchpad.net |
Description of the change
This branch exposes BugNotification
exports the level parameter of IBug.subscribe() so that people can
subscribe at a given BugNotification
== lib/canonical/
- With Leonard's help I've added a helper to allow us to patch the
vocabulary of a Choice param when exported via the API.
== lib/canonical/
- I've added some circular-
for the CI problem I would have used copy_field to copy
IBugSubscrip
== lib/lp/
- I've added the declaration of level as an operation parameter for
IBug.
== lib/lp/
- I've exported IBugSubscriptio
== lib/lp/
- I've updated the existing webservice tests to cover the new
functionality.
Notes from the across-the-table discussion: Level is missing, and promised to add it.
– This is only for direct subscriptions, not for structural subscriptions.
— There are no existing tests for any of the patch_* functions, so none are provided for this thing
— When asked about any "negative" tests, Graham noticed himself that test for patching (editing) a BugSubscription
With that in mind, all good, and approved on the condition of adding a test.