Merge lp:~gmb/launchpad/debbugs-zero-batch-size-bug-444322 into lp:launchpad

[Graham Binns]

[Graham Binns (gmb)]

This branch is a simple fix for bug 444322. It removes the batch_size limit for the DebBugs ExternalBugTracker, which has the effect of letting checkwatches alway update all the needs-checking watches for DebBugs every time it runs rather than only updating the first 100.

[Abel Deuring (adeuring)]

review: Approve (code)

=== modified file 'lib/lp/bugs/doc/externalbugtracker-debbugs.txt'
--- lib/lp/bugs/doc/externalbugtracker-debbugs.txt	2009-06-15 11:10:49 +0000
+++ lib/lp/bugs/doc/externalbugtracker-debbugs.txt	2009-10-06 07:45:29 +0000
@@ -38,6 +38,13 @@
     >>> verifyObject(IExternalBugTracker, external_debbugs)
     True
 
+Because we keep a local copy of the DebBugs database we don't need to
+worry about batching bug watch updates for performance reasons, so
+DebBugs instances don't have a batch_size limit.
+
+    >>> print external_debbugs.batch_size
+    None
+
 
 == Retrieving bug status from the debbugs database ==
 

=== modified file 'lib/lp/bugs/externalbugtracker/debbugs.py'
--- lib/lp/bugs/externalbugtracker/debbugs.py	2009-06-25 00:40:31 +0000
+++ lib/lp/bugs/externalbugtracker/debbugs.py	2009-10-06 07:45:29 +0000
@@ -57,6 +57,11 @@
     debbugs_pl = os.path.join(
         os.path.dirname(debbugs.__file__), 'debbugs-log.pl')
 
+    # Because we keep a local copy of debbugs, we remove the batch_size
+    # limit so that all debbugs watches that need checking will be
+    # checked each time checkwatches runs.
+    batch_size = None
+
     def __init__(self, baseurl, db_location=None):
         super(DebBugs, self).__init__(baseurl)
         if db_location is None: