Merge lp:~gmb/launchpad/bug-999554 into lp:launchpad
Proposed by
Graham Binns
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15261 |
Proposed branch: | lp:~gmb/launchpad/bug-999554 |
Merge into: | lp:launchpad |
Diff against target: |
58 lines (+11/-4) 3 files modified
lib/lp/blueprints/stories/sprints/xx-sprint-meeting-export.txt (+9/-0) lib/lp/blueprints/templates/sprint-meeting-export.pt (+2/-1) lib/lp/bugs/model/tests/test_bug.py (+0/-3) |
To merge this branch: | bzr merge lp:~gmb/launchpad/bug-999554 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Francesco Banconi (community) | code* | Approve | |
Review via email:
|
Description of the change
This branch fixes bug 999554 by adding an ID field to the Specification export in $sprint/
I've added a test to cover the change (that view is not very well tested) and removed some unused imports to offset the LoC change a bit.
To post a comment you must log in.
Graham, your branch looks good, thank you.
I've just spotted a problem: at line 8 of the diff you removed an interface previously exposed through the webservice.
This generate an error during AppServerLayer set up, e.g. running::
bin/test -t lp.bugs. model.tests. test_bugtask. TestWebservice
Approved with that fix. Waiting for rvba approval.