Merge lp:~gmb/launchpad/bug-606914 into lp:launchpad/db-devel

[Graham Binns]

Bug.initial_message has been changed to use Storm rather than materialising and sorting all the messages to then only return one.

This branch fixes the bizarrely sucky implementation of Bug.initial_message, which previously materialised all the messages, sorted them and then returned the first one. Which is just daft. So I've changed it to use Storm.

There are a lot of tests covering this, but you can run bin/test -cvvt bugs-emailinterface.txt to be sure.

[Robert Collins (lifeless)]

The VWS on line 15 is a bit jarring. I'd delete it personally.

review: Approve

=== modified file 'lib/lp/bugs/model/bug.py'
--- lib/lp/bugs/model/bug.py	2010-07-14 12:00:01 +0000
+++ lib/lp/bugs/model/bug.py	2010-07-19 12:11:20 +0000
@@ -494,8 +494,12 @@
     @property
     def initial_message(self):
         """See `IBug`."""
-        messages = sorted(self.messages, key=lambda ob: ob.id)
-        return messages[0]
+        store = Store.of(self)
+        messages = store.find(
+            Message,
+            BugMessage.bug == self,
+            BugMessage.message == Message.id).order_by('id')
+        return messages.first()
 
     def followup_subject(self):
         """See `IBug`."""