Merge lp:~gmb/launchpad/bug-1-timeout into lp:launchpad

[Graham Binns]

[r=benji][ui=none][no-qa] Bug._indexed_message()'s signature now matches that declared in the IBug interface.

This branch changes the default for the include_parents parameter on Bug._indexed_message() to False, so that it matches the declaration on IBug._indexed_message(). There is a possibility that this will fix bug 744888, but I won't be able to tell until this has landed.

It doesn't, however, cause any test failures, which is at least something.

[Benji York (benji)]

This looks fine.

> It doesn't, however, cause any test failures, which is at least something.

It seems to me the "something" is that the impact of the default value
is not tested, unfortunately.

review: Approve (code)

[Robert Collins (lifeless)]

A better way to do changes like this is to just override that
parameter in the callsite that matters.

I suspect that this change will cause massive timeouts in the API for
bugs, because parent calculation is expensive when done late.

[Robert Collins (lifeless)]

Actually, when I say timeouts, I should say 'will break the API by deleting all parent relations shown on the API'.

[Graham Binns (gmb)]

On Tuesday, 5 April 2011, Robert Collins <email address hidden> wrote:
> Actually, when I say timeouts, I should say 'will break the API by deleting all parent relations shown on the API'.

Okay. We should probably revert this, then :). We need to add some
tests to cover the expected behaviour, though, because nothing broke
when I changed the default on the model to match what's declared in
the interface,

--
Graham Binns
http://grahambinns.com

[William Grant (wgrant)]

It has been reverted. Yes, it does need tests.

[Robert Collins (lifeless)]

An appropriate test would be 'the api shows parent links for messages
with parents'. A simple model check is probably there today but
insufficient because the API != the model [because performance].

=== modified file 'lib/lp/bugs/model/bug.py'
--- lib/lp/bugs/model/bug.py	2011-04-05 06:13:17 +0000
+++ lib/lp/bugs/model/bug.py	2011-04-05 16:49:12 +0000
@@ -452,7 +452,7 @@
         # value (in the absence of slices)
         return self._indexed_messages(include_content=True)
 
-    def _indexed_messages(self, include_content=False, include_parents=True):
+    def _indexed_messages(self, include_content=False, include_parents=False):
         """Get the bugs messages, indexed.
 
         :param include_content: If True retrieve the content for the messages