Merge lp:~gmb/launchpad/blob-processing-job-table-bug-513762 into lp:launchpad/db-devel

[Graham Binns]

Add an ApportJob table so that the Jobs system can be used to process Apport BLOBs.

[Graham Binns (gmb)]

This branch adds an ApportJob table for storing data about Apport blob-processing jobs.

[Jonathan Lange (jml)]

Needs comments, probably needs indexes. Still not sure how I feel about the name.

In principle, I'm OK with it.

review: Needs Fixing (db)

[Graham Binns (gmb)]

Argh, comments added.

Jono, I know what you mean about the table name not being terribly good, but I can't think of a better one. Can you?

[Stuart Bishop (stub)]

Job should be unique I think, and an index is needed:

ALTER TABLE ApportJob ADD CONSTRAINT apportjob__job__key UNIQUE (job);

CREATE INDEX apportjob__blob__idx ON ApportJob(blob);

patch-2207-30-0.sql

review: Approve

[Jonathan Lange (jml)]

Looks great, thanks.

review: Approve (db)

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2010-02-02 18:21:45 +0000
+++ database/schema/comments.sql	2010-02-03 15:57:15 +0000
@@ -22,6 +22,13 @@
 COMMENT ON COLUMN AnswerContact.person IS 'The person or team associated with the question target.';
 COMMENT ON COLUMN AnswerContact.date_created IS 'The date the answer contact was submitted.';
 
+-- ApportJob
+
+COMMENT ON TABLE ApportJob IS 'Contains references to jobs to be run against Apport BLOBs.';
+COMMENT ON COLUMN ApportJob.blob IS 'The TemporaryBlobStorage entry on which the job is to be run.';
+COMMENT ON COLUMN ApportJob.job_type IS 'The type of job (enumeration value). Allows us to query the database for a given subset of ApportJobs.';
+COMMENT ON COLUMN ApportJob.json_data IS 'A JSON struct containing data for the job.';
+
 -- Branch
 COMMENT ON TABLE Branch IS 'Bzr branch';
 COMMENT ON COLUMN Branch.registrant IS 'The user that registered the branch.';

=== added file 'database/schema/patch-2207-30-0.sql'
--- database/schema/patch-2207-30-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2207-30-0.sql	2010-02-03 15:57:15 +0000
@@ -0,0 +1,14 @@
+SET client_min_messages=ERROR;
+
+CREATE TABLE ApportJob(
+    id serial NOT NULL PRIMARY KEY,
+    job integer NOT NULL REFERENCES Job(id),
+    blob integer NOT NULL REFERENCES TemporaryBlobStorage(id),
+    job_type integer NOT NULL,
+    json_data text
+);
+
+ALTER TABLE ApportJob ADD CONSTRAINT apportjob__job__key UNIQUE (job);
+CREATE INDEX apportjob__blob__idx ON ApportJob(blob);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2207, 30, 0)