Merge lp:~gmb/launchpad/another-checkwatches-keyerror-bug-497414 into lp:launchpad/db-devel
Proposed by
Graham Binns
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | not available |
Merged at revision: | not available |
Proposed branch: | lp:~gmb/launchpad/another-checkwatches-keyerror-bug-497414 |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
128 lines (+93/-1) 2 files modified
lib/lp/bugs/scripts/checkwatches.py (+10/-1) lib/lp/bugs/scripts/tests/test_checkwatches.py (+83/-0) |
To merge this branch: | bzr merge lp:~gmb/launchpad/another-checkwatches-keyerror-bug-497414 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Canonical Launchpad Engineering | code | Pending | |
Review via email: mp+16243@code.launchpad.net |
Commit message
Catch another KeyError in checkwatches.
To post a comment you must log in.
This branch fixes bug 497414 by stopping a KeyError from being raised in checkwatches.
I've added a regression test for the bug and also a test to make sure that the new code logs an error appropriately.