Merge lp:~glower/ols-jenkaas/serial-vault into lp:~ols-jenkaas-admins/ols-jenkaas/trunk

Proposed by Igor Komlew
Status: Rejected
Rejected by: Daniel Manrique
Proposed branch: lp:~glower/ols-jenkaas/serial-vault
Merge into: lp:~ols-jenkaas-admins/ols-jenkaas/trunk
Diff against target: 15 lines (+3/-0)
1 file modified
jobs/serial-vault.yaml (+3/-0)
To merge this branch: bzr merge lp:~glower/ols-jenkaas/serial-vault
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+392280@code.launchpad.net

Commit message

Added parameterized-snap-store-staging-deploy jenkins job to serial-vault

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

2 configs are missing: staging-rollout-command and deploy-group

review: Needs Fixing
lp:~glower/ols-jenkaas/serial-vault updated
768. By Igor Komlew

Added missing config

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Looks good, will hold landing this until the new user is setup in wendigo with the proper ssh keys, etc

review: Approve
Revision history for this message
Igor Komlew (glower) wrote :

OK, make sense

Revision history for this message
Daniel Manrique (roadmr) wrote :

Rejecting to clear the queue (it's been almost 2 years), feel free to clone and repropose this branch if still needed.

Unmerged revisions

768. By Igor Komlew

Added missing config

767. By Igor Komlew

Added parameterized-staging-deploy-on-charm-changes job to serial-vault

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/serial-vault.yaml'
2--- jobs/serial-vault.yaml 2020-09-30 17:38:06 +0000
3+++ jobs/serial-vault.yaml 2020-10-15 12:56:00 +0000
4@@ -7,8 +7,11 @@
5 build-command: 'make vendor-ci mkdir-tmp build-tarball charm-bootstrap && make publish-tarball charm-publish http_proxy='
6 deps-trunk: 'lp:~ubuntuone-pqm-team/serial-vault/+git/dependencies'
7 charm-repo: 'lp:~ubuntuone-pqm-team/serial-vault/+git/charm-build'
8+ deploy-group: 'serial-vault'
9+ staging-rollout-command: 'ssh stg-serial-vault@wendigo.canonical.com'
10 jobs:
11 - 'land-{name}-dependencies'
12 - '{name}-build-asset'
13 - '{name}-build-charm'
14 - 'trigger-{name}-build-charm-on-changes'
15+ - 'trigger-{name}-parameterized-staging-deploy-on-charm-changes'

Subscribers

People subscribed via source and target branches