Merge lp:~gleichsnerd/ubuntu/precise/mountall/fix-for-805509 into lp:ubuntu/precise/mountall
| Status: | Rejected |
|---|---|
| Rejected by: | Martin Pitt on 2012-05-30 |
| Proposed branch: | lp:~gleichsnerd/ubuntu/precise/mountall/fix-for-805509 |
| Merge into: | lp:ubuntu/precise/mountall |
| Diff against target: |
43 lines (+33/-0) 1 file modified
man/mountall.8 (+33/-0) |
| To merge this branch: | bzr merge lp:~gleichsnerd/ubuntu/precise/mountall/fix-for-805509 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Didier Roche | Approve on 2012-05-30 | ||
| Micah Gersten | 2012-05-30 | Pending | |
| Adam Gleichsner | Pending | ||
| Ubuntu branches | 2012-05-30 | Pending | |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-03-31.
Description of the Change
As requested in #805509, I added the options for mountall to the man page, as written in mountall --help.
Testing is straightforward, just backup the old mountall man page and throw in this one. Everything should come out all squeaky clean and beautiful.
**5/29/12 -- Formatting updated/fixed; resubmitted
| James Hunt (jamesodhunt) wrote : | # |
Hi Adam - thank you very much for your contribution. A few minor comments:
- All dashes ('-') should be escaped so rather than '--debug', you should specify '\-\-debug'.
- '--dev-
- 'value' in '--dev-wait-time' is not underlined.
- Formatting is wrong for '--dev-wait-time'.
- '--quiet' and '--verbose' are not displaying in bold as the other options are.
Take a look at the init-checkconf(8) man page as this has examples of all the above scenarios:
vim $(man -w init-checkconf)
| Adam Gleichsner (gleichsnerd) wrote : | # |
Sorry for the hiatus, I had some hardware malfunctions that put me out of commission for awhile.
I fixed the formatting as per James' request. Hopefully it's all set to go now.
Let me know if anything else needs to be done.
-Adam
P.S. @Micah - The Canonical copyright is fine.
| James Hunt (jamesodhunt) wrote : | # |
Hi Adam,
Thanks very much for your work on this - looks great now!
(BTW - if you're interested, we don't yet have a man page for /sbin/mntctl in the mountall package).
| Didier Roche (didrocks) wrote : | # |
Merged in lp:ubuntu/mountall trunk after some discussion with jodh. Thanks! (this branch will be rejected as wrong target)
| Adam Gleichsner (gleichsnerd) wrote : | # |
@James Hunt,
I would be happy to. I just submitted a bug report to link to it; I'll get cracking right away.
Unmerged revisions
- 383. By Adam Gleichsner on 2012-05-30
-
Fixed formatting errors
- 382. By Adam Gleichsner on 2012-03-31
-
Added options to mountall(8) man page


This looks great, thanks. Are you ok with this patch being under Canonical copyright?