Merge lp:~gleichsnerd/ubuntu/precise/mountall/fix-for-805509 into lp:ubuntu/precise/mountall

Proposed by Adam Gleichsner
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~gleichsnerd/ubuntu/precise/mountall/fix-for-805509
Merge into: lp:ubuntu/precise/mountall
Diff against target: 43 lines (+33/-0)
1 file modified
man/mountall.8 (+33/-0)
To merge this branch: bzr merge lp:~gleichsnerd/ubuntu/precise/mountall/fix-for-805509
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Ubuntu branches Pending
Adam Gleichsner Pending
Micah Gersten Pending
Review via email: mp+107908@code.launchpad.net

This proposal supersedes a proposal from 2012-03-31.

Description of the change

As requested in #805509, I added the options for mountall to the man page, as written in mountall --help.

Testing is straightforward, just backup the old mountall man page and throw in this one. Everything should come out all squeaky clean and beautiful.

**5/29/12 -- Formatting updated/fixed; resubmitted

To post a comment you must log in.
Revision history for this message
Micah Gersten (micahg) wrote : Posted in a previous version of this proposal

This looks great, thanks. Are you ok with this patch being under Canonical copyright?

review: Needs Information
Revision history for this message
James Hunt (jamesodhunt) wrote : Posted in a previous version of this proposal

Hi Adam - thank you very much for your contribution. A few minor comments:

- All dashes ('-') should be escaped so rather than '--debug', you should specify '\-\-debug'.
- '--dev-wait-time=value' should be '\-\-dev\-wait\-time=\fIvalue\fP'.
- 'value' in '--dev-wait-time' is not underlined.
- Formatting is wrong for '--dev-wait-time'.
- '--quiet' and '--verbose' are not displaying in bold as the other options are.

Take a look at the init-checkconf(8) man page as this has examples of all the above scenarios:

    vim $(man -w init-checkconf)

Revision history for this message
Adam Gleichsner (gleichsnerd) wrote : Posted in a previous version of this proposal

Sorry for the hiatus, I had some hardware malfunctions that put me out of commission for awhile.

I fixed the formatting as per James' request. Hopefully it's all set to go now.

Let me know if anything else needs to be done.

-Adam

P.S. @Micah - The Canonical copyright is fine.

review: Needs Resubmitting
Revision history for this message
James Hunt (jamesodhunt) wrote :

Hi Adam,

Thanks very much for your work on this - looks great now!

(BTW - if you're interested, we don't yet have a man page for /sbin/mntctl in the mountall package).

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Merged in lp:ubuntu/mountall trunk after some discussion with jodh. Thanks! (this branch will be rejected as wrong target)

review: Approve
Revision history for this message
Adam Gleichsner (gleichsnerd) wrote :

@James Hunt,

I would be happy to. I just submitted a bug report to link to it; I'll get cracking right away.

Unmerged revisions

383. By Adam Gleichsner

Fixed formatting errors

382. By Adam Gleichsner

Added options to mountall(8) man page

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'man/mountall.8'
2--- man/mountall.8 2009-09-16 22:38:18 +0000
3+++ man/mountall.8 2012-05-30 03:17:18 +0000
4@@ -25,6 +25,39 @@
5 itself gains the necessary flexibility to perform this processing; you
6 should not rely on its behaviour.
7 .\"
8+.SH OPTIONS
9+
10+.BR \-\-daemon
11+\ Detach and run in the background
12+
13+.BR \-\-force-fsck
14+\ Force check of all filesystems
15+
16+.BR \-\-fsck-fix
17+\ Attempt to fix all fsck errors
18+
19+.BR \-\-no-events
20+\ Do not emit events after mounting filesystems
21+
22+.BR \-\-dev\-wait\-time=\fIvalue\fP " (in seconds)"
23+ (Default is 30 seconds, Legal value
24+ is between 1 to 2147483647)
25+ In case of (bootwait,timeout): specify
26+ the time to wait for device to be detected
27+
28+.BR \-q " , " \-\-quiet
29+\ Reduce output to errors only
30+
31+.BR \-v " , " \-\-verbose
32+\ Increase output to include informational
33+ messages
34+
35+.BR \-\-help
36+\ Display this help and exit
37+
38+.BR \-\-version
39+\ Output version information and exit
40+.\"
41 .SH AUTHOR
42 Written by Scott James Remnant
43 .RB < scott@netsplit.com >

Subscribers

People subscribed via source and target branches