Code review comment for lp:~gl-az/percona-xtrabackup/bug1243009-2.0

Vlad Lesin (vlad-lesin) wrote :

Looks good.

But I have question about IB_ARGS:
1) What is the reason of changing the type of this variable from scalar to vector? The only reason I saw is the ability to remove certain element from this vector in innobackupex_no_defaults_file(). But "sed" could be used for this purpose. And if we don't change the type of this variable there is no need in the most of changes concerned with this variable type;
2) If we change the type if this variable we should change it everywhere. But IB_ARGS is still scalar in ./test/run.sh:318, ./test/t/server_version.sh:24.

review: Needs Fixing (g2)

« Back to merge proposal