Merge lp:~gl-az/percona-server/bug1273465-5.5 into lp:percona-server/5.5
Status: | Work in progress |
---|---|
Proposed branch: | lp:~gl-az/percona-server/bug1273465-5.5 |
Merge into: | lp:percona-server/5.5 |
Diff against target: |
112 lines (+9/-9) 8 files modified
libmysql/errmsg.c (+1/-1) sql/log_event.cc (+1/-1) sql/log_event.h (+1/-1) sql/rpl_utility.cc (+1/-1) sql/sql_select.cc (+2/-2) sql/tztime.cc (+1/-1) storage/innobase/fil/fil0fil.c (+1/-1) storage/myisam/mi_rnext.c (+1/-1) |
To merge this branch: | bzr merge lp:~gl-az/percona-server/bug1273465-5.5 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Needs Fixing on 2014-01-28 | ||
Laurynas Biveinis (community) | 2014-01-27 | Needs Fixing on 2014-01-28 | |
Review via email:
|
Description of the change
Fix for bug1273465 - lintian warnings and errors (new packaging)
Corrected minor spelling errors with the exception of 'yuR' as that does not appear anywhere in the code base.
George Ormond Lorch III (gl-az) wrote : | # |
Is there a reason not to do a GCA and a 5.6 branch? (and those typos should be reported to upstream too)
Alexey Kopytov (akopytov) wrote : | # |
Lintian complains about spelling errors in strings found in the binary image (i.e. it executes 'strings' and checks the output about common spelling mistakes). What's the point to modify code comments?
George Ormond Lorch III (gl-az) wrote : | # |
Laurynas, I did start with branches fresh out of the percona_
> percona_
==> mkdir bug1273465
==> bzr branch lp:percona-server/5.6 bug1273465/5.6
Branched 537 revisions.
==> bzr branch lp:percona-server/5.5 bug1273465/5.5
Branched 620 revisions.
Getting the oldest unmerged mainline revision for lp:percona-server/5.5
Using revision 608
Updating bug1273465/5.5 to the last fully merged mainline revision
==> cd bug1273465/5.5
==> bzr pull -q --overwrite -rbefore:608 .
bzr: ERROR: Moving the root directory is not supported at this time
I'll look into this some today.
Yes Laurynas, most of these issues exist upstream as well.
Alexey, I agree, changing source code comments and minor spelling errors IMHO should not be a rational reason to be excluded from a distro. I was asked to do the work under the pretense that it has been vetted and deemed necessary. Please advise otherwise on the JIRA task.
Unmerged revisions
- 608. By George Ormond Lorch III on 2014-01-27
-
Fix for bug1273465 - lintian warnings and errors (new packaging)
Corrected minor spelling errors with the exception of 'yuR' as that does not appear anywhere in the code base.
jenkins http:// jenkins. percona. com/view/ PS%205. 5/job/percona- server- 5.5-param/ 936/