Created by George Ormond Lorch III and last modified
Get this branch:
bzr branch lp:~gl-az/percona-server/ST-29716-bug1135097-5.5
Only George Ormond Lorch III can upload to this branch. If you are George Ormond Lorch III please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Recent revisions

461. By George Ormond Lorch III on 2013-03-05

Fix for upstream bugs.mysql.com/bug.php?id=68490 and bugs.launchpad.net/percona-server/+bug/1135097

When reconnecting to the master, the mysql client library in sql-common/client.c::mysql_reconnect creates a new 'tmp' MYSQL* with all default values (overwriting the MYSQL::net.max_packet_size with default). It then copies the contents of the tmp back into the passed in MYSQL*.

This causes issues with the slave connection when reconnecting because: 1) The code in handle_slave_io(...) is not setting the mysql->option.max_allowed_packet but directly manipulating the mysql->net.max_packet_size which gets reset when the connection is recreated as described above, and 2) the mysql->options.max_allowed_packet is being set in the top of handle_slave_io(...) and not in connect_to_master(...) where all other client options are being set for the connection and thus is not always properly set to the correct value depending on the reason for reconnecting.

The fix is somewhat simple, in sql/slave.cc, moves lines 2838-2845 from handle_slave_io to line 4270 and change:
  mysql->net.max_packet_size= thd->net.max_packet_size+= MAX_LOG_EVENT_HEADER;
  mysql->options.max_allowed_packet= thd->net.max_packet_size+= MAX_LOG_EVENT_HEADER;

Added test suite/rpl/t/rpl_packet_bug68490.test

460. By <email address hidden> on 2013-02-28

Merge lp:~percona-core/percona-server/release-5.5.29-30.0

459. By <email address hidden> on 2013-02-27

Merge lp:~akopytov/percona-server/bug1123921

458. By <email address hidden> on 2013-02-27

Merge lp:~akopytov/percona-server/bug1132350

457. By <email address hidden> on 2013-02-27

Merge lp:~akopytov/percona-server/bug1132351

456. By <email address hidden> on 2013-02-27

Empty merge from Percona Server 5.1

455. By <email address hidden> on 2013-02-27

Empty merge from Percona Server 5.1

454. By <email address hidden> on 2013-02-26

Merge lp:~hrvojem/percona-server/rn-5.5.29-30.0-fix

453. By <email address hidden> on 2013-02-26

Merge lp:~akopytov/percona-server/bug1123915

452. By <email address hidden> on 2013-02-26

Merge lp:~akopytov/percona-server/bug1130655

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.